Re: [Qemu-devel] [PULL 00/57] Migration pull

[Juan Quintela <quintela@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> wrote:
> On 9 November 2015 at 17:28, Juan Quintela <quintela@redhat.com> wrote:
>>
>> Hi
>>
>> two items:
>>
>> - Postcopy pull request (dave)
>> - fix for qemu_completion (Denis)
>>
>> Please apply.
>>
>> Thanks, Juan.
>>
>>
>> The following changes since commit ce278618b088afd10b91a05311eaeb6401bb5004:
>>
>>   configure: Don't disable optimization for non-fortify builds
>> (2015-11-09 16:28:09 +0000)
>>
>> are available in the git repository at:
>>
>>   git://github.com/juanquintela/qemu.git tags/migration/20151109
>>
>> for you to fetch changes up to d1de612d6ed199a52a6f4823d89c1731c74edcb6:
>>
>>   migration: qemu_savevm_state_cleanup becomes mandatory operation
>> (2015-11-09 18:26:06 +0100)
>>
>> ----------------------------------------------------------------
>> migration/next for 20151109
>>
>> ----------------------------------------------------------------
>
> Fails to build on W32:
>
> cc1: warnings being treated as errors
> /home/petmay01/linaro/qemu-for-merges/migration/migration.c: In
> function ‘source_return_path_thread’:
> /home/petmay01/linaro/qemu-for-merges/migration/migration.c:1289:
> warning: format ‘%zd’ expects type ‘signed size_t’, but argument 5 has
> type ‘ssize_t’

After asking around on irc, "poll" favoured %zd for printing ssize_t
values.  But clearly your crosscompiler don't agree.  So what to do:

- another pull request with %ld .... (long) .... cast?  Ugly but should
  work.
- you change it yourself?
- any other suggestion?

I test compiled it on x86_64 and i686 linux, and with w32 and w64
compilers, so I thought that I have covered the normal cases.

Later, Juan.


>   CC    migration/block.o
> make: *** [migration/migration.o] Error 1
> make: *** Waiting for unfinished jobs....
>   CC    net/net.o
> cc1: warnings being treated as errors
> /home/petmay01/linaro/qemu-for-merges/migration/qemu-file-unix.c: In
> function ‘socket_writev_buffer’:
> /home/petmay01/linaro/qemu-for-merges/migration/qemu-file-unix.c:59:
> warning: format ‘%zd’ expects type ‘signed size_t’, but argument 3 has
> type ‘ssize_t’
> /home/petmay01/linaro/qemu-for-merges/migration/qemu-file-unix.c:59:
> warning: format ‘%zd’ expects type ‘signed size_t’, but argument 4 has
> type ‘ssize_t’
> make: *** [migration/qemu-file-unix.o] Error 1
>
> thanks
> -- PMM