From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvrV8-0007sL-Ap for qemu-devel@nongnu.org; Mon, 09 Nov 2015 13:49:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvrV5-0000jx-4v for qemu-devel@nongnu.org; Mon, 09 Nov 2015 13:49:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvrV4-0000jr-Ve for qemu-devel@nongnu.org; Mon, 09 Nov 2015 13:49:07 -0500 From: Juan Quintela In-Reply-To: (Peter Maydell's message of "Mon, 9 Nov 2015 17:50:45 +0000") References: <1447090141-29074-1-git-send-email-quintela@redhat.com> Date: Mon, 09 Nov 2015 19:49:03 +0100 Message-ID: <87si4f80v4.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/57] Migration pull Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Amit Shah , QEMU Developers , "Dr. David Alan Gilbert" Peter Maydell wrote: > On 9 November 2015 at 17:28, Juan Quintela wrote: >> >> Hi >> >> two items: >> >> - Postcopy pull request (dave) >> - fix for qemu_completion (Denis) >> >> Please apply. >> >> Thanks, Juan. >> >> >> The following changes since commit ce278618b088afd10b91a05311eaeb6401bb5= 004: >> >> configure: Don't disable optimization for non-fortify builds >> (2015-11-09 16:28:09 +0000) >> >> are available in the git repository at: >> >> git://github.com/juanquintela/qemu.git tags/migration/20151109 >> >> for you to fetch changes up to d1de612d6ed199a52a6f4823d89c1731c74edcb6: >> >> migration: qemu_savevm_state_cleanup becomes mandatory operation >> (2015-11-09 18:26:06 +0100) >> >> ---------------------------------------------------------------- >> migration/next for 20151109 >> >> ---------------------------------------------------------------- > > Fails to build on W32: > > cc1: warnings being treated as errors > /home/petmay01/linaro/qemu-for-merges/migration/migration.c: In > function =E2=80=98source_return_path_thread=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/migration/migration.c:1289: > warning: format =E2=80=98%zd=E2=80=99 expects type =E2=80=98signed size_t= =E2=80=99, but argument 5 has > type =E2=80=98ssize_t=E2=80=99 After asking around on irc, "poll" favoured %zd for printing ssize_t values. But clearly your crosscompiler don't agree. So what to do: - another pull request with %ld .... (long) .... cast? Ugly but should work. - you change it yourself? - any other suggestion? I test compiled it on x86_64 and i686 linux, and with w32 and w64 compilers, so I thought that I have covered the normal cases. Later, Juan. > CC migration/block.o > make: *** [migration/migration.o] Error 1 > make: *** Waiting for unfinished jobs.... > CC net/net.o > cc1: warnings being treated as errors > /home/petmay01/linaro/qemu-for-merges/migration/qemu-file-unix.c: In > function =E2=80=98socket_writev_buffer=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/migration/qemu-file-unix.c:59: > warning: format =E2=80=98%zd=E2=80=99 expects type =E2=80=98signed size_t= =E2=80=99, but argument 3 has > type =E2=80=98ssize_t=E2=80=99 > /home/petmay01/linaro/qemu-for-merges/migration/qemu-file-unix.c:59: > warning: format =E2=80=98%zd=E2=80=99 expects type =E2=80=98signed size_t= =E2=80=99, but argument 4 has > type =E2=80=98ssize_t=E2=80=99 > make: *** [migration/qemu-file-unix.o] Error 1 > > thanks > -- PMM