From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1ZQIP8-0006aV-45
	for qemu-devel@nongnu.org; Fri, 14 Aug 2015 13:04:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1ZQIP3-0004Oq-Dr
	for qemu-devel@nongnu.org; Fri, 14 Aug 2015 13:04:29 -0400
Received: from mail-out.m-online.net ([212.18.0.9]:34930)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1ZQIP3-0004Oi-6n
	for qemu-devel@nongnu.org; Fri, 14 Aug 2015 13:04:25 -0400
From: Andreas Schwab <schwab@linux-m68k.org>
References: <1439564366-11633-1-git-send-email-rth@twiddle.net>
	<1439564366-11633-4-git-send-email-rth@twiddle.net>
Date: Fri, 14 Aug 2015 19:04:21 +0200
In-Reply-To: <1439564366-11633-4-git-send-email-rth@twiddle.net> (Richard
	Henderson's message of "Fri, 14 Aug 2015 07:59:18 -0700")
Message-ID: <87si7lvm22.fsf@igel.home>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect
	clearing of cc_x
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, gerg@uclinux.org, qemu-devel@nongnu.org, laurent@vivier.eu

Richard Henderson <rth@twiddle.net> writes:

> The CF docs certainly doesnt suggest this is true.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-m68k/helper.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/target-m68k/helper.c b/target-m68k/helper.c
> index c7b0fbe..6feb4bf 100644
> --- a/target-m68k/helper.c
> +++ b/target-m68k/helper.c
> @@ -205,19 +205,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
>          break;
>      case CC_OP_LOGICB:
>          SET_NZ(dest, int8_t);
> -        goto set_x;
>          break;
>      case CC_OP_LOGICW:
>          SET_NZ(dest, int16_t);
> -        goto set_x;
>          break;
>      case CC_OP_LOGIC:
>          SET_NZ(dest, int32_t);
> -set_x:
> -        if (!m68k_feature(env, M68K_FEATURE_M68000)) {
> -            /* Unlike m68k, coldfire always clears the overflow bit.  */

I think this refers to the muls/mulu insn, where the CF always clears V.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."