From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTWwi-0000OH-FH for qemu-devel@nongnu.org; Thu, 05 Mar 2015 09:40:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTWwZ-0001qw-9E for qemu-devel@nongnu.org; Thu, 05 Mar 2015 09:40:16 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:60574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTWwY-0001j9-Fs for qemu-devel@nongnu.org; Thu, 05 Mar 2015 09:40:07 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Mar 2015 00:40:01 +1000 From: Nikunj A Dadhania In-Reply-To: <54F85596.30802@suse.de> References: <1425556583-13895-1-git-send-email-nikunj@linux.vnet.ibm.com> <1425556583-13895-3-git-send-email-nikunj@linux.vnet.ibm.com> <54F85596.30802@suse.de> Date: Thu, 05 Mar 2015 20:09:02 +0530 Message-ID: <87sidjwltl.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4 2/2] spapr: override default ram size to 1GB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: thuth@linux.vnet.ibm.com, aik@ozlabs.ru, armbru@redhat.com, qemu-ppc@nongnu.org, marcel.apfelbaum@gmail.com, imammedo@redhat.com Alexander Graf writes: > On 05.03.15 12:56, Nikunj A Dadhania wrote: >> Signed-off-by: Nikunj A Dadhania >> Reviewed-by: Igor Mammedov >> --- >> hw/ppc/spapr.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 23cde20..c71ee4b 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -96,6 +96,7 @@ typedef struct sPAPRMachineState sPAPRMachineState; >> #define SPAPR_MACHINE(obj) \ >> OBJECT_CHECK(sPAPRMachineState, (obj), TYPE_SPAPR_MACHINE) >> >> +#define SPAPR_DEFAULT_RAM_SIZE (1UL << 30) > > UL is almost always wrong on QEMU land. Please use ULL. > > Also I find 1 << 30 pretty hard to read. Can't we just define simple > KB/MB/GB/TB helpers somewhere in a header file and just fold this is > below as .. Ok, let me get a appropriate header for these. > >> /** >> * sPAPRMachineState: >> */ >> @@ -1738,6 +1739,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data) >> mc->max_cpus = MAX_CPUS; >> mc->no_parallel = 1; >> mc->default_boot_order = NULL; >> + mc->default_ram_size = SPAPR_DEFAULT_RAM_SIZE; > > mc->default_ram_size = 1 * GB; > > > Alex > >> mc->kvm_type = spapr_kvm_type; >> mc->has_dynamic_sysbus = true; >> >>