From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51424)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1WXnrh-0002On-TV
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 04:28:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1WXnrc-0005uD-Qm
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 04:28:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1WXnrc-0005u1-C1
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 04:28:08 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <462e8a61547e6833c71ec45adcb45e88561eed66.1395800307.git.alistair.francis@xilinx.com>
	<CAEgOgz4MjGmqx4UojjPmqgn8zD=E3epTxG6dnTEmbbaDtPxsJA@mail.gmail.com>
	<CAKmqyKP9nRV9o2H6TYTwoKYGgY-GZBHdCpSXnJ4cC2x4WoYpzg@mail.gmail.com>
Date: Wed, 09 Apr 2014 10:28:05 +0200
In-Reply-To: <CAKmqyKP9nRV9o2H6TYTwoKYGgY-GZBHdCpSXnJ4cC2x4WoYpzg@mail.gmail.com>
	(Alistair Francis's message of "Wed, 9 Apr 2014 11:34:11 +1000")
Message-ID: <87sipmj4a2.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v1 1/1] zynq_slcr: Change the comma to a
	underscore
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Alistair Francis <alistair.francis@xilinx.com> writes:

> On Wed, Apr 9, 2014 at 11:14 AM, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> On Wed, Mar 26, 2014 at 1:05 PM, Alistair Francis
>> <alistair.francis@xilinx.com> wrote:
>>> This patch changes the comma in the "xilinx,zynq_slcr" to an
>>> underscore. This matches every other xilinx* peripheral and
>>> also makes parsing the device via the command line possible.
>>>
>>
>> I think its actually a case of this being slightly ahead and everyone
>> else being behind. The comma is probably ultimately wrong and I'm
>> guessing its awkward for your command-line work due to command line
>> character escaping. I am in favor of the "xlnx.foo" styling that is
>> more widely adopted:
>>
>> [qemu]$ git grep -c "xlnx\."
>> hw/arm/xilinx_zynq.c:1
>> hw/char/xilinx_uartlite.c:2
>> hw/dma/xilinx_axidma.c:2
>> hw/intc/xilinx_intc.c:2
>> hw/microblaze/petalogix_ml605_mmu.c:6
>> hw/microblaze/petalogix_s3adsp1800_mmu.c:5
>> hw/net/xilinx_axienet.c:3
>> hw/net/xilinx_ethlite.c:2
>> hw/ppc/virtex_ml507.c:2
>> hw/ssi/xilinx_spi.c:1
>> hw/ssi/xilinx_spips.c:2
>> hw/timer/xilinx_timer.c:2
>> target-microblaze/cpu.c:1
>>
>> will xlnx.zynq-slcr work? (fix the underscore while at it).
>
> Full stops are fine, just as long as it is not a comma

The most common separator in device model names is '-'.  There's a fair
number of '.', some '_', and a few ','.

The comma are probably rooted in device tree usage.  I doubt that buys
us anything but confusing command line trouble.

I suspect period breaks -global.

I very much recommend picking '-' whenever practical.