From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT75V-0003zQ-1V for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WT75Q-0001ws-Og for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:59:04 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:47562 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT75Q-0001wn-J2 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 05:59:00 -0400 References: <1395844634-11729-1-git-send-email-alex.bennee@linaro.org> <1395844634-11729-3-git-send-email-alex.bennee@linaro.org> <20140326184927.GB23230@dorilex> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20140326184927.GB23230@dorilex> Date: Thu, 27 Mar 2014 09:59:21 +0000 Message-ID: <87siq4ynba.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qemu-log: support simple pid substitution in logfile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leandro Dorileo Cc: qemu-devel@nongnu.org Leandro Dorileo writes: > On Wed, Mar 26, 2014 at 02:37:12PM +0000, alex.bennee@linaro.org wrote: >> From: Alex Bennée >> >> When debugging stuff that occurs over several forks it would be useful >> not to keep overwriting the one logfile you've set-up. This allows a >> simple %d to be included once in the logfile parameter which is >> substituted with getpid(). > > Looks good to me. Is that a Reviewed-by? If you include a Reviewed-by tag it makes it easier to copy and paste into the commit for the next iteration. -- Alex Bennée