From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45277)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WNTHq-00026q-2l
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:28:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WNTHm-0005Zx-2O
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:28:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WNTHl-0005Yz-QO
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:28:26 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <33183CC9F5247A488A2544077AF19020815D6567@SZXEMA503-MBS.china.huawei.com>
	(Gonglei's message of "Tue, 11 Mar 2014 13:34:45 +0000")
References: <1394542415-5152-1-git-send-email-arei.gonglei@huawei.com>
	<1394542415-5152-3-git-send-email-arei.gonglei@huawei.com>
	<531F0AF2.8060301@redhat.com>
	<33183CC9F5247A488A2544077AF19020815D6567@SZXEMA503-MBS.china.huawei.com>
Date: Tue, 11 Mar 2014 21:28:18 +0100
Message-ID: <87siqo32fx.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 02/10] migration: Add counters of updating
	the dirty bitmap
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "chenliang (T)" <chenliang88@huawei.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "owasserm@redhat.com" <owasserm@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>

"Gonglei (Arei)" <arei.gonglei@huawei.com> wrote:
>> On 03/11/2014 06:53 AM, arei.gonglei@huawei.com wrote:
>> > From: ChenLiang <chenliang88@huawei.com>
>> >
>> > Add counters to log the times of updating the dirty bitmap.
>> >
>> > Signed-off-by: ChenLiang <chenliang88@huawei.com>
>> > Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> > Reviewed-by: Eric Blake <eblake@redhat.com>
>> 
>> Wait - how did my Reviewed-by get here?  There is no [PATCHv2] in the
>> subject line to indicate that I reviewed an earlier revision. and the
>> only other mail I see from me in the archives with the same subject line
>> is here:
>> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05143.html
>> 
>> where I made a comment, but did NOT give my signature on the patch.
>> 
>> Please follow http://wiki.qemu.org/Contribute/SubmitAPatch when using
>> Reviewed-by: tags and subject lines.  Otherwise, you are making life
>> harder for yourself and for reviewers.
>> 
> I'm so sorry for those, and will post a new version.

>> > +static uint64_t bitmap_sync_cnt;

If you change, you can do s/_cnt/_count/?  As suggested in the output
string?

Thanks, Juan.

Later, Juan.