From: Juan Quintela <quintela@redhat.com>
To: Orit Wasserman <owasserm@redhat.com>
Cc: peter.maydell@linaro.org,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
qemu-devel@nongnu.org, anthony@codemonkey.ws,
ChenLiang <chenliang88@huawei.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] migration:fix free XBZRLE decoded_buf wrong
Date: Tue, 04 Feb 2014 16:01:41 +0100 [thread overview]
Message-ID: <87siryj50q.fsf@elfo.mitica> (raw)
In-Reply-To: <1391066055-17024-4-git-send-email-owasserm@redhat.com> (Orit Wasserman's message of "Thu, 30 Jan 2014 09:14:12 +0200")
Orit Wasserman <owasserm@redhat.com> wrote:
> From: "Gonglei (Arei)" <arei.gonglei@huawei.com>
>
> When qemu do live migration with xbzrle, qemu malloc decoded_buf
> at destination end but free it at source end. It will crash qemu
> by double free error in some scenarios. Splitting the XBZRLE structure
> for clear logic distinguishing src/dst side.
>
> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Orit Wasserman <owasserm@redhat.com>
> Signed-off-by: GongLei <arei.gonglei@huawei.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Good catch O:-)
next prev parent reply other threads:[~2014-02-04 18:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 7:14 [Qemu-devel] [PATCH 0/6] XBZRLE Fixes Orit Wasserman
2014-01-30 7:14 ` [Qemu-devel] [PATCH 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors Orit Wasserman
2014-01-30 18:25 ` Eric Blake
2014-01-30 7:14 ` [Qemu-devel] [PATCH 2/6] Add check for cache size smaller than page size Orit Wasserman
2014-01-30 7:14 ` [Qemu-devel] [PATCH 3/6] migration:fix free XBZRLE decoded_buf wrong Orit Wasserman
2014-02-04 15:01 ` Juan Quintela [this message]
2014-01-30 7:14 ` [Qemu-devel] [PATCH 4/6] XBZRLE cache size should not be larger than guest memory size Orit Wasserman
2014-02-04 15:01 ` Juan Quintela
2014-01-30 7:14 ` [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache Orit Wasserman
2014-01-30 15:48 ` Dr. David Alan Gilbert
2014-01-30 17:51 ` Orit Wasserman
2014-01-30 7:14 ` [Qemu-devel] [PATCH 6/6] Don't abort on memory allocation error Orit Wasserman
2014-01-30 16:08 ` Dr. David Alan Gilbert
2014-01-30 17:55 ` Orit Wasserman
2014-02-04 15:00 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siryj50q.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=arei.gonglei@huawei.com \
--cc=chenliang88@huawei.com \
--cc=owasserm@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).