From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAkuO-0008Ke-OW for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:39:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAkuK-00033I-66 for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:39:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAiDj-0000bG-B6 for qemu-devel@nongnu.org; Tue, 04 Feb 2014 10:47:31 -0500 From: Juan Quintela In-Reply-To: <1391066055-17024-4-git-send-email-owasserm@redhat.com> (Orit Wasserman's message of "Thu, 30 Jan 2014 09:14:12 +0200") References: <1391066055-17024-1-git-send-email-owasserm@redhat.com> <1391066055-17024-4-git-send-email-owasserm@redhat.com> Date: Tue, 04 Feb 2014 16:01:41 +0100 Message-ID: <87siryj50q.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 3/6] migration:fix free XBZRLE decoded_buf wrong Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, "Gonglei (Arei)" , qemu-devel@nongnu.org, anthony@codemonkey.ws, ChenLiang Orit Wasserman wrote: > From: "Gonglei (Arei)" > > When qemu do live migration with xbzrle, qemu malloc decoded_buf > at destination end but free it at source end. It will crash qemu > by double free error in some scenarios. Splitting the XBZRLE structure > for clear logic distinguishing src/dst side. > > Signed-off-by: ChenLiang > Reviewed-by: Peter Maydell > Reviewed-by: Orit Wasserman > Signed-off-by: GongLei Reviewed-by: Juan Quintela Good catch O:-)