From: Anthony Liguori <anthony@codemonkey.ws>
To: Stacey Son <sson@FreeBSD.org>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/23] bsd-user: FreeBSD support for mips/mips64 and arm
Date: Mon, 24 Jun 2013 15:07:23 -0500 [thread overview]
Message-ID: <87sj07jmro.fsf@codemonkey.ws> (raw)
In-Reply-To: <457772E5-2342-43BE-9043-5F55BFD030C0@FreeBSD.org>
Stacey Son <sson@FreeBSD.org> writes:
> On Jun 24, 2013, at 12:55 PM, Anthony Liguori wrote:
>
>> There is no humanly way 23k LOC can be reviewed in a single series.
>
> Yes, indeed, it is a lot of code.
>
>> Has this been maintained out of tree for some time?
>
> Yes, it has been a large, ugly patch set in the FreeBSD qemu-devel
> port for some time.
Okay, I assume there were many collaborators then? You may want to
consider collecting some additional Signed-off-bys then from the
original authors. I don't like the idea merging a very large patch
series without preserving authorship info.
>
>> Is it largely
>> copy/paste from linux-user?
>
> A good amount of the initial code came from linux-user but then
> diverged when the code was restructured to put cpu and *BSD dependent
> code into its own subdirs which I believe was the original thought on
> how the code was to be structured.
I think Peter made some suggestions about how to split things up...
Regards,
Anthony Liguori
>
> Regards,
> -stacey.
next prev parent reply other threads:[~2013-06-24 20:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 2:03 [Qemu-devel] [PATCH 00/23] bsd-user: FreeBSD support for mips/mips64 and arm Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 01/23] bsd-user: initial code clean up Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 02/23] bsd-user: add initial support for mips/mips64 Stacey Son
2013-06-24 17:15 ` Peter Maydell
2013-06-24 20:09 ` Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 03/23] bsd-user: additional seperation of OS and architecture dependent code Stacey Son
2013-06-24 17:20 ` Peter Maydell
2013-06-24 17:24 ` Peter Maydell
2013-06-24 20:15 ` Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 04/23] bsd-user: add bsd signal emulation Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 05/23] bsd-user: add bsd_binprm to TaskState for core dumping emulation Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 06/23] bsd-user: fix thread initialization and ELF addresses for mips/mips64 Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 07/23] bsd-user: find target executable in path when absolute path not given Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 08/23] bsd-user: initialize stack with signal trampolin code and canary Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 09/23] bsd-user: refresh FreeBSD's system call numbers Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 10/23] bsd-user: add shims for memory management related syscalls Stacey Son
2013-06-24 17:26 ` Peter Maydell
2013-06-24 2:03 ` [Qemu-devel] [PATCH 11/23] bsd-user: add shims for file related system calls Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 12/23] bsd-user: add shims for time " Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 13/23] bsd-user: add shims for signal " Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 14/23] bsd-user: add shims for process " Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 15/23] bsd-user: add shims for socket " Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 16/23] bsd-user: add shims for stat and file handle related syscalls Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 17/23] bsd-user: add shims for thread related system calls Stacey Son
2013-06-24 17:37 ` Peter Maydell
2013-06-24 20:23 ` Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 18/23] bsd-user: add shim for the ioctl system call Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 19/23] bsd-user: add shims for sysarch() and sysctl() system calls Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 20/23] bsd-user: add shims for extended attributes " Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 21/23] bsd-user: add miscellaneous system call shims Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 22/23] bsd-user: add more strace formating Stacey Son
2013-06-24 17:41 ` Peter Maydell
2013-06-24 20:55 ` Stacey Son
2013-06-24 2:03 ` [Qemu-devel] [PATCH 23/23] bsd-user: add arm cpu support Stacey Son
2013-06-24 17:18 ` Peter Maydell
2013-06-24 17:49 ` [Qemu-devel] [PATCH 00/23] bsd-user: FreeBSD support for mips/mips64 and arm Peter Maydell
2013-06-24 19:18 ` Stacey Son
2013-06-24 17:55 ` Anthony Liguori
2013-06-24 19:29 ` Stacey Son
2013-06-24 20:07 ` Anthony Liguori [this message]
2013-06-24 20:40 ` Stacey Son
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj07jmro.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sson@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).