From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1UnRX0-0003ib-1u
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 06:46:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1UnRWy-0002pp-VL
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 06:46:58 -0400
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:51347)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1UnRWq-0002aD-LY
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 06:46:56 -0400
Received: from /spool/local
	by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <nikunj@linux.vnet.ibm.com>;
	Fri, 14 Jun 2013 20:39:30 +1000
From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
In-Reply-To: <87vc5hro46.fsf@linux.vnet.ibm.com>
References: <87vc5hro46.fsf@linux.vnet.ibm.com>
Date: Fri, 14 Jun 2013 16:02:22 +0530
Message-ID: <87sj0lrnih.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] commit 08521e2 breaks SLOF usb boot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> writes:
> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date:   Fri May 24 12:54:01 2013 +0200
>
>     memory: add big endian support to access_with_adjusted_size
>     
>     This will be used to split 8-byte access down to two four-byte accesses.
>     
>     Reviewed-by: Richard Henderson <rth@twiddle.net>
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
>
> If I hack the above funniness in my USB EHCI driver, somewhere down the
> qemu crashes at code introduced by this patch:
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x0000000000000000 in ?? ()
> (gdb) bt
> #0 0x0000000000000000 in ?? ()
> #1 0x00005555557a0ea4 in access_with_adjusted_size (addr=addr@entry=12, value=value@entry=0x7fffd5a86680, size=size@entry=1, access_size_min=<optimized out>, access_size_max=<optimized out>,
> access=0x5555557a1f80 <memory_region_oldmmio_write_accessor>, opaque=0x5555567f8ab8) at /home/nikunj/work/power/code/qemu/memory.c:396
> #2 0x00005555557a5ebb in memory_region_dispatch_write (size=1, data=0, addr=12, mr=0x5555567f8ab8) at /home/nikunj/work/power/code/qemu/memory.c:998
>
> Reverting this, I can safely boot using a usb-storage device put on ehci controller.

Just reverting this patch does not help though, i will need to figure
which all commits are bad.

Regards
Nikunj