From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Uaopw-0000WF-L6
	for qemu-devel@nongnu.org; Fri, 10 May 2013 11:02:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Uaopv-0008CJ-Dw
	for qemu-devel@nongnu.org; Fri, 10 May 2013 11:02:20 -0400
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:50118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Uaopu-0008C1-S4
	for qemu-devel@nongnu.org; Fri, 10 May 2013 11:02:19 -0400
Received: from /spool/local
	by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Sat, 11 May 2013 00:56:01 +1000
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <CAFEAcA8QHAUDL_rEUP_nuMEwNX_ZW5eXnY=SVKNL+fYAWkFZJg@mail.gmail.com>
References: <1368196799-19982-1-git-send-email-afaerber@suse.de>
	<CAFEAcA8QHAUDL_rEUP_nuMEwNX_ZW5eXnY=SVKNL+fYAWkFZJg@mail.gmail.com>
Date: Fri, 10 May 2013 10:02:02 -0500
Message-ID: <87sj1uzxn9.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary
	dynamic cast in ppc_env_get_cpu()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Andreas =?utf-8?Q?F=C3=A4rbe?= =?utf-8?Q?r?= <afaerber@suse.de>
Cc: pbonzini@redhat.com, "open list:PowerPC" <qemu-ppc@nongnu.org>, qemu-devel@nongnu.org, aurelien@aurel32.net, Alexander Graf <agraf@suse.de>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 10 May 2013 15:39, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> A transition from CPUPPCState to PowerPCCPU can be considered safe,
>> just like PowerPCCPU::env access in the opposite direction.
>>
>> This should slightly improve interrupt performance.
>
>>  static inline PowerPCCPU *ppc_env_get_cpu(CPUPPCState *env)
>>  {
>> -    return POWERPC_CPU(container_of(env, PowerPCCPU, env));
>> +    return container_of(env, PowerPCCPU, env);
>>  }
>
> So if this is worthwhile shouldn't we be doing it for
> all our CPUs?

Ack.

Regards,

Anthony Liguori

>
> thanks
> -- PMM