From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZSNq-00018q-0M for qemu-devel@nongnu.org; Mon, 06 May 2013 16:51:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZSNl-000886-0c for qemu-devel@nongnu.org; Mon, 06 May 2013 16:51:41 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:35356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZSNk-00087i-Ed for qemu-devel@nongnu.org; Mon, 06 May 2013 16:51:36 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 May 2013 06:49:10 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id C0B793578017 for ; Tue, 7 May 2013 06:51:27 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r46KpKlY22937842 for ; Tue, 7 May 2013 06:51:20 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r46KpQ4Z016658 for ; Tue, 7 May 2013 06:51:26 +1000 From: Anthony Liguori In-Reply-To: <20130506150027.GA22689@redhat.com> References: <20130506150027.GA22689@redhat.com> Date: Mon, 06 May 2013 15:51:17 -0500 Message-ID: <87sj1zvnlm.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.5] virtio-pci: bugfix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , KONRAD Frederic "Michael S. Tsirkin" writes: > mask notifiers are never called without msix, > so devices with backend masking like vhost don't work. > Call mask notifiers explicitly at > startup/cleanup to make it work. > > Signed-off-by: Michael S. Tsirkin > Tested-by: Alexander Graf /home/aliguori/git/qemu/hw/virtio/virtio-pci.c: In function =E2=80=98virtio= _pci_set_guest_notifier=E2=80=99: /home/aliguori/git/qemu/hw/virtio/virtio-pci.c:761:54: error: =E2=80=98Virt= IODevice=E2=80=99 has no member named =E2=80=98guest_notifier_mask=E2=80=99 /home/aliguori/git/qemu/hw/virtio/virtio-pci.c:762:20: error: =E2=80=98Virt= IODevice=E2=80=99 has no member named =E2=80=98guest_notifier_mask=E2=80=99 CC hw/virtio/dataplane/hostmem.o make: *** [hw/virtio/virtio-pci.o] Error 1 Regards, Anthony Liguori > > --- > hw/virtio/virtio-pci.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 8bba0f3..d0fcc6c 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -758,6 +758,10 @@ static int virtio_pci_set_guest_notifier(DeviceState= *d, int n, bool assign, > event_notifier_cleanup(notifier); > } >=20=20 > + if (!msix_enabled(&proxy->pci_dev) && proxy->vdev->guest_notifier_ma= sk) { > + proxy->vdev->guest_notifier_mask(proxy->vdev, n, !assign); > + } > + > return 0; > } >=20=20 > --=20 > MST