From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40677)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TDh93-0002Pr-Tn
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 15:38:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TDh8y-0002lP-2c
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 15:38:13 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:37631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TDh8x-0002lB-U4
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 15:38:08 -0400
Received: by obbta14 with SMTP id ta14so8913516obb.4
	for <qemu-devel@nongnu.org>; Mon, 17 Sep 2012 12:38:07 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <1342383972-11640-1-git-send-email-vapier@gentoo.org>
References: <1342383972-11640-1-git-send-email-vapier@gentoo.org>
Date: Mon, 17 Sep 2012 14:38:04 -0500
Message-ID: <87sjagtp7n.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mike Frysinger <vapier@gentoo.org>, qemu-devel@nongnu.org

Mike Frysinger <vapier@gentoo.org> writes:

> We should not quote the PKG_CONFIG setting as this deviates from the
> canonical upstream behavior that gets integrated with all other build
> systems, and deviates from how we treat all other toolchain variables
> that we get from the environment.
>
> Ultimately, the point is that it breaks passing custom flags directly
> to pkg-config via the env var where this normally works elsewhere,
> and it used to work in the past.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

This doesn't make any sense to me.   What is the command line that
you're trying to execute?

This obviously would introduce a bug if there was a space in the
filename of the pkg-config binary.

Regards,

Anthony Liguori

> ---
>  configure |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 83fa1ca..bd12ed3 100755
> --- a/configure
> +++ b/configure
> @@ -245,7 +245,7 @@ strip="${STRIP-${cross_prefix}strip}"
>  windres="${WINDRES-${cross_prefix}windres}"
>  pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}"
>  query_pkg_config() {
> -    "${pkg_config_exe}" ${QEMU_PKG_CONFIG_FLAGS} "$@"
> +    ${pkg_config_exe} ${QEMU_PKG_CONFIG_FLAGS} "$@"
>  }
>  pkg_config=query_pkg_config
>  sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
> @@ -1511,7 +1511,7 @@ fi
>  ##########################################
>  # pkg-config probe
>  
> -if ! has "$pkg_config_exe"; then
> +if ! has $pkg_config_exe; then
>    echo "Error: pkg-config binary '$pkg_config_exe' not found"
>    exit 1
>  fi
> -- 
> 1.7.9.7