Re: [PATCH-for-11.1 v6 1/6] target/sparc/monitor: Dump all registers as 32-bit

[Markus Armbruster <armbru@redhat.com>]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> All these SPARC64 registers are 32-bit since their introduction
> in commit 3475187dd81 ("sparc64 merge"), see target/sparc/cpu.h:
>
>   511 #if defined(TARGET_SPARC64)
>   ...
>   515     uint32_t asi;
>   516     uint32_t pstate;
>   ...
>   519     uint32_t cansave, canrestore, otherwin, wstate, cleanwin;
>
> Set MonitorDef::type to MD_I32 to dump them as 32-bit.

What are they dumped as before this patch?

> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/sparc/monitor.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/target/sparc/monitor.c b/target/sparc/monitor.c
> index a60671a60a4..e9300ded4ad 100644
> --- a/target/sparc/monitor.c
> +++ b/target/sparc/monitor.c
> @@ -41,13 +41,13 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict)
>  
>  const MonitorDef monitor_defs[] = {
>  #ifdef TARGET_SPARC64
> -    { "asi", offsetof(CPUSPARCState, asi) },
> -    { "pstate", offsetof(CPUSPARCState, pstate) },
> -    { "cansave", offsetof(CPUSPARCState, cansave) },
> -    { "canrestore", offsetof(CPUSPARCState, canrestore) },
> -    { "otherwin", offsetof(CPUSPARCState, otherwin) },
> -    { "wstate", offsetof(CPUSPARCState, wstate) },
> -    { "cleanwin", offsetof(CPUSPARCState, cleanwin) },
> +    { "asi", offsetof(CPUSPARCState, asi), NULL, MD_I32 },
> +    { "pstate", offsetof(CPUSPARCState, pstate), NULL, MD_I32 },
> +    { "cansave", offsetof(CPUSPARCState, cansave), NULL, MD_I32 },
> +    { "canrestore", offsetof(CPUSPARCState, canrestore), NULL, MD_I32 },
> +    { "otherwin", offsetof(CPUSPARCState, otherwin), NULL, MD_I32 },
> +    { "wstate", offsetof(CPUSPARCState, wstate), NULL, MD_I32 },
> +    { "cleanwin", offsetof(CPUSPARCState, cleanwin), NULL, MD_I32 },
>  #endif
>      { NULL },
>  };