From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Juraj Marcin" <jmarcin@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 0/3] migration/tls: Graceful shutdowns for main and postcopy channels
Date: Wed, 17 Sep 2025 17:56:40 -0300 [thread overview]
Message-ID: <87tt10vlvb.fsf@suse.de> (raw)
In-Reply-To: <aMLK5nT4CVPrcZCB@x1.local>
Peter Xu <peterx@redhat.com> writes:
> On Wed, Sep 10, 2025 at 12:01:41PM -0400, Peter Xu wrote:
>> Fabiano fixed graceful shutdowns for multifd channels previously:
>>
>> https://lore.kernel.org/qemu-devel/20250206175824.22664-1-farosas@suse.de/
>>
>> However we likely forgot the rest channels. Do it the same for the main
>> and postcopy channels. This fixes a warning message when running unit test
>> /ARCH/migration/postcopy/preempt/tls/psk.
>>
>> Thanks,
>>
>> Peter Xu (3):
>> migration/tls: Gracefully shutdown main and preempt channels
>> migration: Make migration_has_failed() work even for CANCELLING
>> migration/multifd: Use the new graceful termination helper
>
> Please hold off the review on this one. Juraj reported the issue wasn't
> resolved by the changes, and I can also reproduce. I'll have a look and
> repost..
I'm wondering if the assumption that only succeeded migrations should
gracefully exit is correct. My understanding is that we need to always
exit gracefully, but after failure, the channel might not be there, so
we ignore failures. But that does not seem to mean a failed migration
can simply not exit gracefully.
next prev parent reply other threads:[~2025-09-17 20:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 16:01 [PATCH 0/3] migration/tls: Graceful shutdowns for main and postcopy channels Peter Xu
2025-09-10 16:01 ` [PATCH 1/3] migration/tls: Gracefully shutdown main and preempt channels Peter Xu
2025-09-17 20:22 ` Fabiano Rosas
2025-09-10 16:01 ` [PATCH 2/3] migration: Make migration_has_failed() work even for CANCELLING Peter Xu
2025-09-17 20:52 ` Fabiano Rosas
2025-09-17 22:00 ` Peter Xu
2025-09-18 13:43 ` Fabiano Rosas
2025-09-10 16:01 ` [PATCH 3/3] migration/multifd: Use the new graceful termination helper Peter Xu
2025-09-17 21:07 ` Fabiano Rosas
2025-09-11 13:13 ` [PATCH 0/3] migration/tls: Graceful shutdowns for main and postcopy channels Peter Xu
2025-09-17 20:56 ` Fabiano Rosas [this message]
2025-09-17 21:50 ` Peter Xu
2025-09-18 13:47 ` Fabiano Rosas
2025-09-18 16:15 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt10vlvb.fsf@suse.de \
--to=farosas@suse.de \
--cc=berrange@redhat.com \
--cc=jmarcin@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).