Re: [PATCH 0/3] migration/tls: Graceful shutdowns for main and postcopy channels

[Fabiano Rosas <farosas@suse.de>]

Peter Xu <peterx@redhat.com> writes:

> On Wed, Sep 10, 2025 at 12:01:41PM -0400, Peter Xu wrote:
>> Fabiano fixed graceful shutdowns for multifd channels previously:
>> 
>> https://lore.kernel.org/qemu-devel/20250206175824.22664-1-farosas@suse.de/
>> 
>> However we likely forgot the rest channels.  Do it the same for the main
>> and postcopy channels.  This fixes a warning message when running unit test
>> /ARCH/migration/postcopy/preempt/tls/psk.
>> 
>> Thanks,
>> 
>> Peter Xu (3):
>>   migration/tls: Gracefully shutdown main and preempt channels
>>   migration: Make migration_has_failed() work even for CANCELLING
>>   migration/multifd: Use the new graceful termination helper
>
> Please hold off the review on this one.  Juraj reported the issue wasn't
> resolved by the changes, and I can also reproduce.  I'll have a look and
> repost..

I'm wondering if the assumption that only succeeded migrations should
gracefully exit is correct. My understanding is that we need to always
exit gracefully, but after failure, the channel might not be there, so
we ignore failures. But that does not seem to mean a failed migration
can simply not exit gracefully.