From: "Alex Bennée" <alex.bennee@linaro.org>
To: Osama Abdelkader <osama.abdelkader@gmail.com>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/arm/boot: replace fprintf with error_report
Date: Tue, 02 Sep 2025 10:22:47 +0100 [thread overview]
Message-ID: <87tt1lyzrs.fsf@draig.linaro.org> (raw)
In-Reply-To: <aLYXHdYRlLyjr7Gc@osama> (Osama Abdelkader's message of "Mon, 1 Sep 2025 23:58:53 +0200")
Osama Abdelkader <osama.abdelkader@gmail.com> writes:
> On Mon, Sep 01, 2025 at 05:59:03PM +0100, Alex Bennée wrote:
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>> > On Sat, 23 Aug 2025 at 16:03, Osama Abdelkader
>> > <osama.abdelkader@gmail.com> wrote:
>> >>
>> >> Replace direct fprintf(stderr, …) with QEMU's error_report() API,
>> >> which ensures consistent formatting and integrates with QEMU's
>> >> logging infrastructure.
>> >>
>> >> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
>> >> ---
>> >> hw/arm/boot.c | 22 +++++++++++-----------
>> >> 1 file changed, 11 insertions(+), 11 deletions(-)
>> >
>> >
>> >
>> > Applied to target-arm.next, thanks.
>>
>> I didn't see this had been posted but I did a more extensive clean-up
>> here:
>>
>> Message-ID: <20250901125304.1047624-1-alex.bennee@linaro.org>
>> Date: Mon, 1 Sep 2025 13:53:00 +0100
>> Subject: [PATCH 0/4] arm_load_dtb cleanups
>> From: =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
>>
>> >
>> > -- PMM
>>
>> --
>> Alex Bennée
>> Virtualisation Tech Lead @ Linaro
>
> sorry Alex, I didn't know that your patch set covers that.
No need to apologise - qemu-devel is a firehose of patches so its
inevitable two or more people might touch the same thing at the same
time.
> I just submitted a simple patch to replace fprintf in raspi4b
> Would appreciate your review.
I have left some comments.
>
> Thank you.
>
> Regards,
> Osama
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2025-09-02 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 15:03 [PATCH] hw/arm/boot: replace fprintf with error_report Osama Abdelkader
2025-09-01 16:24 ` Peter Maydell
2025-09-01 16:59 ` Alex Bennée
2025-09-01 21:58 ` Osama Abdelkader
2025-09-02 9:22 ` Alex Bennée [this message]
2025-09-02 8:37 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt1lyzrs.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=osama.abdelkader@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).