From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Prasad Pandit" <ppandit@redhat.com>,
"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
"Cédric Le Goater" <clg@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
peterx@redhat.com, "Avihai Horon" <avihaih@nvidia.com>
Subject: Re: [PATCH v3 6/7] migration/multifd: Cleanup src flushes on condition check
Date: Mon, 09 Dec 2024 17:55:19 -0300 [thread overview]
Message-ID: <87ttbca85k.fsf@suse.de> (raw)
In-Reply-To: <20241206224755.1108686-7-peterx@redhat.com>
Peter Xu <peterx@redhat.com> writes:
> The src flush condition check is over complicated, and it's getting more
> out of control if postcopy will be involved.
>
> In general, we have two modes to do the sync: legacy or modern ways.
> Legacy uses per-section flush, modern uses per-round flush.
>
> Mapped-ram always uses the modern, which is per-round.
>
> Introduce two helpers, which can greatly simplify the code, and hopefully
> make it readable again.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2024-12-09 20:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 22:47 [PATCH v3 0/7] migration/multifd: Some VFIO / postcopy preparations on flush Peter Xu
2024-12-06 22:47 ` [PATCH v3 1/7] migration/multifd: Further remove the SYNC on complete Peter Xu
2024-12-06 22:47 ` [PATCH v3 2/7] migration/multifd: Allow to sync with sender threads only Peter Xu
2024-12-09 20:52 ` Fabiano Rosas
2024-12-06 22:47 ` [PATCH v3 3/7] migration/ram: Move RAM_SAVE_FLAG* into ram.h Peter Xu
2024-12-06 22:47 ` [PATCH v3 4/7] migration/multifd: Unify RAM_SAVE_FLAG_MULTIFD_FLUSH messages Peter Xu
2024-12-06 22:47 ` [PATCH v3 5/7] migration/multifd: Remove sync processing on postcopy Peter Xu
2024-12-06 22:47 ` [PATCH v3 6/7] migration/multifd: Cleanup src flushes on condition check Peter Xu
2024-12-09 20:55 ` Fabiano Rosas [this message]
2024-12-06 22:47 ` [PATCH v3 7/7] migration/multifd: Document the reason to sync for save_setup() Peter Xu
2024-12-09 20:56 ` Fabiano Rosas
2024-12-17 15:26 ` [PATCH v3 0/7] migration/multifd: Some VFIO / postcopy preparations on flush Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttbca85k.fsf@suse.de \
--to=farosas@suse.de \
--cc=alex.williamson@redhat.com \
--cc=avihaih@nvidia.com \
--cc=clg@redhat.com \
--cc=mail@maciej.szmigiero.name \
--cc=peterx@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).