qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] .travis.yml: Install python3-tomli in all build jobs
Date: Mon, 24 Jun 2024 11:09:22 +0100	[thread overview]
Message-ID: <87tthips8d.fsf@draig.linaro.org> (raw)
In-Reply-To: <20240624094807.182313-1-thuth@redhat.com> (Thomas Huth's message of "Mon, 24 Jun 2024 11:48:07 +0200")

Thomas Huth <thuth@redhat.com> writes:

> Since commit 1f97715c83 ('Revert "python: use vendored tomli"')
> this package is a hard requirement for compiling QEMU, so install
> it now in all Travis jobs, too.

AFAICT the only repo currently running these tests is your github
mirror:

  https://app.travis-ci.com/github/huth/qemu/builds?serverType=git

Because both the official github mirror and the gitlab project haven't
run anything for a while:

  https://app.travis-ci.com/gitlab/qemu-project/qemu/branches
  https://app.travis-ci.com/github/qemu/qemu/branches

I've never been able to get anything to build since they transitioned to
TravisCI.com

>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .travis.yml | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index cef0308952..8fc1ae0cf2 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -106,6 +106,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -141,6 +142,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -175,6 +177,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -215,6 +218,7 @@ jobs:
>            - libzstd-dev
>            - nettle-dev
>            - ninja-build
> +          - python3-tomli
>            # Tests dependencies
>            - genisoimage
>        env:
> @@ -231,6 +235,7 @@ jobs:
>            - ninja-build
>            - flex
>            - bison
> +          - python3-tomli
>        env:
>          - TEST_CMD="make check check-tcg V=1"
>          - CONFIG="--disable-containers --disable-system"
> @@ -263,6 +268,7 @@ jobs:
>            - libvdeplug-dev
>            - libvte-2.91-dev
>            - ninja-build
> +          - python3-tomli
>        env:
>          - TEST_CMD="make check-unit"
>          - CONFIG="--disable-containers --disable-tcg --enable-kvm --disable-tools

FWIW the changes themselves look fine:

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  reply	other threads:[~2024-06-24 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24  9:48 [PATCH] .travis.yml: Install python3-tomli in all build jobs Thomas Huth
2024-06-24 10:09 ` Alex Bennée [this message]
2024-06-24 10:31   ` Thomas Huth
2024-08-20  8:51     ` Stefan Weil via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tthips8d.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).