From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: "Luc Michel" <luc.michel@amd.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH v5 06/12] tests/plugin/mem: migrate to new per_vcpu API
Date: Thu, 29 Feb 2024 13:46:56 +0000 [thread overview]
Message-ID: <87ttlr9ycv.fsf@draig.linaro.org> (raw)
In-Reply-To: <03ce19fb-0b82-4819-aaa4-a2241517090e@linaro.org> (Pierrick Bouvier's message of "Thu, 29 Feb 2024 11:12:03 +0400")
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> On 2/29/24 11:08 AM, Alex Bennée wrote:
>> Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
>>
>>> On 2/29/24 2:08 AM, Alex Bennée wrote:
>>>> Luc Michel <luc.michel@amd.com> writes:
>>>>
>>>>> Hi Pierrick,
>>>>>
>> <snip>
>>>>
>>>
>>> My bad. Other plugins enable only inline when both are supplied, so I
>>> missed this here.
>>> I added an explicit error when user enable callback and inline at the
>>> same time on this plugin.
>> We could default to inline unless we need the more features of
>> callbacks?
>>
>
> This remark applies for all plugins in general. Now we have safe and
> correct inline operations, callbacks are not needed in some case.
>
> Would that be acceptable for you that we delay this "cleanup" to
> existing plugins after soft freeze? So we can focus on merging current
> API changes needed.
As long as we fix the double reporting bug sure.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-02-29 13:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 9:14 [PATCH v5 00/12] TCG Plugin inline operation enhancement Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 01/12] plugins: scoreboard API Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 02/12] plugins: define qemu_plugin_u64 Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 03/12] plugins: implement inline operation relative to cpu_index Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 04/12] plugins: add inline operation per vcpu Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 05/12] tests/plugin: add test plugin for inline operations Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 06/12] tests/plugin/mem: migrate to new per_vcpu API Pierrick Bouvier
2024-02-27 9:35 ` Luc Michel
2024-02-27 10:56 ` Pierrick Bouvier
2024-02-27 14:27 ` Luc Michel
2024-02-28 22:08 ` Alex Bennée
2024-02-29 5:19 ` Pierrick Bouvier
2024-02-29 7:08 ` Alex Bennée
2024-02-29 7:12 ` Pierrick Bouvier
2024-02-29 13:46 ` Alex Bennée [this message]
2024-03-01 9:41 ` Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 07/12] tests/plugin/insn: " Pierrick Bouvier
2024-02-27 9:50 ` Luc Michel
2024-02-26 9:14 ` [PATCH v5 08/12] tests/plugin/bb: " Pierrick Bouvier
2024-02-27 10:02 ` Luc Michel
2024-02-29 14:21 ` Alex Bennée
2024-03-01 9:58 ` Pierrick Bouvier
2024-03-01 10:26 ` Alex Bennée
2024-03-01 10:47 ` Pierrick Bouvier
2024-02-26 9:14 ` [PATCH v5 09/12] contrib/plugins/hotblocks: " Pierrick Bouvier
2024-02-27 10:54 ` Luc Michel
2024-02-27 11:09 ` Pierrick Bouvier
2024-02-27 14:26 ` Luc Michel
2024-02-28 8:04 ` Pierrick Bouvier
2024-02-29 14:33 ` Alex Bennée
2024-03-01 13:21 ` Luc Michel
2024-02-26 9:14 ` [PATCH v5 10/12] contrib/plugins/howvec: " Pierrick Bouvier
2024-02-29 14:35 ` Alex Bennée
2024-02-29 14:40 ` Alex Bennée
2024-02-26 9:14 ` [PATCH v5 11/12] plugins: remove non per_vcpu inline operation from API Pierrick Bouvier
2024-02-29 14:41 ` Alex Bennée
2024-02-26 9:14 ` [PATCH v5 12/12] plugins: cleanup codepath for previous inline operation Pierrick Bouvier
2024-02-29 14:42 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttlr9ycv.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=luc.michel@amd.com \
--cc=ma.mandourr@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).