From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 06/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index
Date: Tue, 27 Jun 2023 12:10:20 +0100 [thread overview]
Message-ID: <87ttutyx4r.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_cOT9phmZevCz6mu+4U92sk9SeBsP-eux3w-c3tDcToA@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Tue, 27 Jun 2023 at 10:57, Alex Bennée <alex.bennee@linaro.org> wrote:
>> Ahh in the other thread. No change, it looks like AltGr just doesn't
>> exist for some keymaps:
>>
>> 🕙21:20:36 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22) [$!?]
>> ➜ diff -ub gb.before gb.after
>> 🕙21:20:43 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22) [$!?]
>> ➜ diff -ub ara.before ara.after
>> 🕙21:20:50 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22) [$!?]
>> ➜ ag "Alt" ara.after
>> 21:# 9: Alt
>> 23:# 11: LAlt
>> 24:# 12: RAlt
>> 29:# 17: AltGr
>> 294:Alt_L 0x38
>> 1711:Alt_R 0xb8
>> 🕙21:22:14 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22) [$!?]
>> ➜ ag "Alt" gb.after
>> 21:# 9: Alt
>> 23:# 11: LAlt
>> 24:# 12: RAlt
>> 29:# 17: AltGr
>> 338:Alt_L 0x38
>> 1757:Alt_R 0xb8
>
> I'm having some difficulty interpreting this output. It
> seems to show that there is an AltGr modifier in both
> mappings (that's why it appears in the modifier listing).
> And for me (xkeyboard-config 2.33) in the gb mapping it's
> used too:
>
> # evdev 2 (0x2), QKeyCode "1", number 0x2
> 1 0x02
> exclam 0x02 shift
> onesuperior 0x02 altgr
> exclamdown 0x02 shift altgr
>
> (i.e. the '1' key is 1 with no modifiers, ! with shift,
> superscript-1 with altgr, and inverted exclamation mark
> with shift-altgr).
>
> The 'ara' keymap likewise has and uses altgr:
> # evdev 2 (0x2), QKeyCode "1", number 0x2
> 1 0x02
> exclam 0x02 shift
> Arabic_1 0x02 altgr
Ahh right I see those too.
>
> So on the machines where we were running into this,
> what's the version of xkeyboard-config and do we
> output the same mapping as we do on machines with
> the older xkeyboard-config ?
2.35 I think:
ii xkb-data 2.35.1-1 all X Keyboard Extension (XKB) configuration data
>
> thanks
> -- PMM
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-06-27 11:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 21:59 [PATCH v2 00/26] maintainer omnibus: testing, fuzz, plugins, documentation Alex Bennée
2023-06-26 21:59 ` [PATCH v2 01/26] gitlab: explicit set artifacts publishing criteria Alex Bennée
2023-06-26 21:59 ` [PATCH v2 02/26] gitlab: ensure coverage job also publishes meson log Alex Bennée
2023-06-26 21:59 ` [PATCH v2 03/26] gitlab: reduce testing scope of check-gcov Alex Bennée
2023-06-26 21:59 ` [PATCH v2 04/26] docs/devel: remind developers to run CI container pipeline when updating images Alex Bennée
2023-06-26 21:59 ` [PATCH v2 05/26] tests/tcg: add mechanism to handle plugin arguments Alex Bennée
2023-06-26 21:59 ` [PATCH v2 06/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index Alex Bennée
2023-06-27 6:50 ` Thomas Huth
2023-06-27 6:55 ` Richard Henderson
2023-06-27 9:56 ` Alex Bennée
2023-06-27 10:26 ` Peter Maydell
2023-06-27 11:10 ` Alex Bennée [this message]
2023-06-26 21:59 ` [PATCH v2 07/26] scripts/oss-fuzz: add a suppression for keymap Alex Bennée
2023-06-26 21:59 ` [PATCH v2 08/26] tests/qtests: clean-up and fix leak in generic_fuzz Alex Bennée
2023-06-27 7:43 ` Juan Quintela
2023-06-27 8:53 ` Philippe Mathieu-Daudé
2023-06-27 9:57 ` Alex Bennée
2023-06-27 7:54 ` Alexander Bulekov
2023-06-26 21:59 ` [PATCH v2 09/26] tests/docker: add test-fuzz Alex Bennée
2023-06-27 9:18 ` Alexander Bulekov
2023-06-26 21:59 ` [PATCH v2 10/26] Makefile: add lcitool-refresh to UNCHECKED_GOALS Alex Bennée
2023-06-26 21:59 ` [PATCH v2 11/26] tests/lcitool: update to latest version Alex Bennée
2023-06-26 21:59 ` [PATCH v2 12/26] tests/lcitool: Bump fedora container versions Alex Bennée
2023-06-26 21:59 ` [PATCH v2 13/26] tests/lcitool: add an explicit gcc-native package Alex Bennée
2023-06-26 21:59 ` [PATCH v2 14/26] tests/lcitool: introduce qemu-minimal Alex Bennée
2023-06-26 21:59 ` [PATCH v2 15/26] tests/docker: convert riscv64-cross to lcitool Alex Bennée
2023-06-26 21:59 ` [PATCH v2 16/26] tests/avocado: update firmware to enable sbsa-ref/max Alex Bennée
2023-06-26 21:59 ` [PATCH v2 17/26] plugins: force slow path when plugins instrument memory ops Alex Bennée
2023-06-26 21:59 ` [PATCH v2 18/26] plugins: fix memory leak while parsing options Alex Bennée
2023-06-26 21:59 ` [PATCH v2 19/26] plugins: update lockstep to use g_memdup2 Alex Bennée
2023-06-26 21:59 ` [PATCH v2 20/26] docs/devel: add some front matter to the devel index Alex Bennée
2023-06-26 21:59 ` [PATCH v2 21/26] include/migration: mark vmstate_register() as a legacy function Alex Bennée
2023-06-26 21:59 ` [PATCH v2 22/26] include/hw/qdev-core: fixup kerneldoc annotations Alex Bennée
2023-06-26 21:59 ` [PATCH v2 23/26] docs/devel/qom.rst: Correct code style Alex Bennée
2023-06-26 21:59 ` [PATCH v2 24/26] docs/devel: split qom-api reference into new file Alex Bennée
2023-06-26 21:59 ` [PATCH v2 25/26] docs/devel: introduce some key concepts for QOM development Alex Bennée
2023-06-26 21:59 ` [PATCH v2 26/26] tests/plugin: Remove duplicate insn log from libinsn.so Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttutyx4r.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).