qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] postcopy-ram: do not use qatomic_mb_read
Date: Mon, 10 Apr 2023 10:40:09 +0200	[thread overview]
Message-ID: <87ttxonn9y.fsf@secure.mitica> (raw)
In-Reply-To: <20230406101612.241872-1-pbonzini@redhat.com> (Paolo Bonzini's message of "Thu, 6 Apr 2023 12:16:12 +0200")

Paolo Bonzini <pbonzini@redhat.com> wrote:
> It does not even pair with a qatomic_mb_set(), so it is clearer to use
> load-acquire in this case; they are synonyms.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

queued on my tree.

I guess this is for 8.1, right?

Later, Juan.

> ---
>  migration/postcopy-ram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index 41c07136501a..23befd5ca8a2 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -1495,7 +1495,7 @@ static PostcopyState incoming_postcopy_state;
>  
>  PostcopyState  postcopy_state_get(void)
>  {
> -    return qatomic_mb_read(&incoming_postcopy_state);
> +    return qatomic_load_acquire(&incoming_postcopy_state);
>  }
>  
>  /* Set the state and return the old state */



      reply	other threads:[~2023-04-10  8:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 10:16 [PATCH] postcopy-ram: do not use qatomic_mb_read Paolo Bonzini
2023-04-10  8:40 ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttxonn9y.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).