From: Juan Quintela <quintela@redhat.com>
To: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/2] migration: allow multifd for socket protocol only
Date: Thu, 09 Sep 2021 09:28:50 +0200 [thread overview]
Message-ID: <87tuiub425.fsf@secure.mitica> (raw)
In-Reply-To: <20210731140552.8818-1-lizhijian@cn.fujitsu.com> (Li Zhijian's message of "Sat, 31 Jul 2021 22:05:51 +0800")
Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
> multifd with unsupported protocol will cause a segment fault.
> (gdb) bt
> #0 0x0000563b4a93faf8 in socket_connect (addr=0x0, errp=0x7f7f02675410) at ../util/qemu-sockets.c:1190
> #1 0x0000563b4a797a03 in qio_channel_socket_connect_sync
> (ioc=0x563b4d16e8c0, addr=0x0, errp=0x7f7f02675410) at
> ../io/channel-socket.c:145
> #2 0x0000563b4a797abf in qio_channel_socket_connect_worker (task=0x563b4cd86c30, opaque=0x0) at ../io/channel-socket.c:168
> #3 0x0000563b4a792631 in qio_task_thread_worker (opaque=0x563b4cd86c30) at ../io/task.c:124
> #4 0x0000563b4a91da69 in qemu_thread_start (args=0x563b4c44bb80) at ../util/qemu-thread-posix.c:541
> #5 0x00007f7fe9b5b3f9 in ?? ()
> #6 0x0000000000000000 in ?? ()
>
> It's enough to check migrate_multifd_is_allowed() in multifd cleanup() and
> multifd setup() though there are so many other places using migrate_use_multifd().
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2021-09-09 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 14:05 [PATCH v2 1/2] migration: allow multifd for socket protocol only Li Zhijian
2021-07-31 14:05 ` [PATCH v2 2/2] migration: allow enabling mutilfd for specific " Li Zhijian
2021-09-09 7:30 ` Juan Quintela
2021-08-23 3:32 ` [PATCH v2 1/2] migration: allow multifd for socket " lizhijian
2021-09-09 7:28 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuiub425.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).