From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH 04/21] linux-user/arm: Implement setup_sigtramp
Date: Wed, 16 Jun 2021 14:49:59 +0100 [thread overview]
Message-ID: <87tulxgbqw.fsf@linaro.org> (raw)
In-Reply-To: <87y2b9gbx7.fsf@linaro.org> ("Alex Bennée"'s message of "Wed, 16 Jun 2021 14:46:12 +0100")
Alex Bennée <alex.bennee@linaro.org> writes:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> ARM is more complicated than the others, in that we also
>> have trampolines for using SA_RESTORER with FDPIC, and
>> we need to create trampolines for both ARM and Thumb modes.
>>
>> Cc: qemu-arm@nongnu.org
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> linux-user/arm/target_signal.h | 2 +
>> linux-user/arm/signal.c | 170 +++++++++++++++++++--------------
>> 2 files changed, 100 insertions(+), 72 deletions(-)
>>
>> +
>> + /* ARM sigframe */
>> + _Static_assert(SIGFRAME_FDPIC_OFS <= 0xfff);
>> + __put_user(0xe59d9000 | SIGFRAME_FDPIC_OFS, &tramp[i++]);
>> + __put_user(0xe8998200, &tramp[i++]);
>
> Erm is this based on your c11 series?
Actually it's merged already so I'm seeing the following on hackbox:
FAILED: libqemu-armeb-linux-user.fa.p/linux-user_arm_signal.c.o
cc -Ilibqemu-armeb-linux-user.fa.p -I. -I../.. -Itarget/arm -I../../target/arm -I../../linux-user/host/x86_64 -Ilinux-user -I../../linux-user -Ilinux-user/arm -I../../linux-
user/arm -I../../capstone/include/capstone -Itrace -Iqapi -Iui/shader -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=auto -pipe -Wa
ll -Winvalid-pch -Werror -std=gnu99 -O2 -g -isystem /home/alex.bennee/lsrc/qemu.git/linux-headers -isystem linux-headers -iquote . -iquote /home/alex.bennee/lsrc/qemu.git -i
quote /home/alex.bennee/lsrc/qemu.git/include -iquote /home/alex.bennee/lsrc/qemu.git/disas/libvixl -iquote /home/alex.bennee/lsrc/qemu.git/tcg/i386 -pthread -U_FORTIFY_SOUR
CE -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototype
s -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wemp
ty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-stro
ng -isystem../../linux-headers -isystemlinux-headers -DNEED_CPU_H '-DCONFIG_TARGET="armeb-linux-user-config-target.h"' '-DCONFIG_DEVICES="armeb-linux-user-config-devices.h"'
-MD -MQ libqemu-armeb-linux-user.fa.p/linux-user_arm_signal.c.o -MF libqemu-armeb-linux-user.fa.p/linux-user_arm_signal.c.o.d -o libqemu-armeb-linux-user.fa.p/linux-user_ar
m_signal.c.o -c ../../linux-user/arm/signal.c
../../linux-user/arm/signal.c: In function ‘setup_sigtramp’:
../../linux-user/arm/signal.c:847:47: error: expected ‘,’ before ‘)’ token
_Static_assert(SIGFRAME_FDPIC_OFS <= 0xfff);
^
../../linux-user/arm/signal.c:852:51: error: expected ‘,’ before ‘)’ token
_Static_assert(SIGFRAME_FDPIC_OFS <= 0xff << 2);
^
../../linux-user/arm/signal.c:853:49: error: expected ‘,’ before ‘)’ token
_Static_assert((SIGFRAME_FDPIC_OFS & 3) == 0);
^
../../linux-user/arm/signal.c:858:50: error: expected ‘,’ before ‘)’ token
_Static_assert(RT_SIGFRAME_FDPIC_OFS <= 0xfff);
^
../../linux-user/arm/signal.c:863:54: error: expected ‘,’ before ‘)’ token
_Static_assert(RT_SIGFRAME_FDPIC_OFS <= 0xff << 2);
^
../../linux-user/arm/signal.c:864:52: error: expected ‘,’ before ‘)’ token
_Static_assert((RT_SIGFRAME_FDPIC_OFS & 3) == 0);
--
Alex Bennée
next prev parent reply other threads:[~2021-06-16 13:50 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 1:11 [PATCH 00/21] linux-user: Move signal trampolines to new page Richard Henderson
2021-06-16 1:11 ` [PATCH 01/21] linux-user: Add infrastructure for a signal trampoline page Richard Henderson
2021-06-16 13:36 ` Max Filippov
2021-06-16 1:11 ` [PATCH 02/21] linux-user/aarch64: Implement setup_sigtramp Richard Henderson
2021-06-16 17:00 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 03/21] linux-user/arm: Force v2 frames for fdpic Richard Henderson
2021-06-16 17:01 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 04/21] linux-user/arm: Implement setup_sigtramp Richard Henderson
2021-06-16 13:46 ` Alex Bennée
2021-06-16 13:49 ` Alex Bennée [this message]
2021-06-16 17:40 ` Richard Henderson
2021-06-16 1:11 ` [PATCH 05/21] linux-user/alpha: " Richard Henderson
2021-06-16 16:56 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 06/21] linux-user/cris: " Richard Henderson
2021-06-16 16:37 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 07/21] linux-user/hexagon: " Richard Henderson
2021-06-16 8:07 ` Taylor Simpson
2021-06-16 15:05 ` Richard Henderson
2021-06-16 15:50 ` Richard Henderson
2021-06-16 21:37 ` Taylor Simpson
2021-06-16 23:15 ` Richard Henderson
2021-06-16 1:11 ` [PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp Richard Henderson
2021-06-16 10:46 ` Philippe Mathieu-Daudé
2021-06-16 21:16 ` Alex Bennée
2021-06-16 1:11 ` [PATCH 09/21] linux-user/i386: Implement setup_sigtramp Richard Henderson
2021-06-16 1:11 ` [PATCH 10/21] linux-user/m68k: " Richard Henderson
2021-06-16 16:42 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 11/21] linux-user/microblaze: " Richard Henderson
2021-06-16 16:43 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 12/21] linux-user/mips: " Richard Henderson
2021-06-16 16:48 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 13/21] linux-user/nios2: Document non-use of setup_sigtramp Richard Henderson
2021-06-16 1:12 ` [PATCH 14/21] linux-user/openrisc: Implement setup_sigtramp Richard Henderson
2021-06-16 16:49 ` Philippe Mathieu-Daudé
2021-06-17 0:24 ` Stafford Horne
2021-06-16 1:12 ` [PATCH 15/21] linux-user/ppc: " Richard Henderson
2021-06-16 1:12 ` [PATCH 16/21] linux-user/riscv: " Richard Henderson
2021-06-16 16:50 ` Philippe Mathieu-Daudé
2021-06-18 1:29 ` Alistair Francis
2021-06-16 1:12 ` [PATCH 17/21] linux-user/s390x: " Richard Henderson
2021-06-16 16:52 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 18/21] linux-user/sh4: " Richard Henderson
2021-06-16 16:53 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 19/21] linux-user/sparc: " Richard Henderson
2021-06-16 1:12 ` [PATCH 20/21] linux-user/xtensa: " Richard Henderson
2021-06-16 13:35 ` Max Filippov
2021-06-16 1:12 ` [PATCH 21/21] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE Richard Henderson
2021-06-16 16:54 ` Philippe Mathieu-Daudé
2021-06-16 15:05 ` [PATCH 00/21] linux-user: Move signal trampolines to new page Alex Bennée
2021-06-16 15:09 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tulxgbqw.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).