From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Laurent Vivier" <laurent@vivier.eu>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 0/5] Drop float32/float64 accessors used by gdbstub code
Date: Tue, 09 Feb 2021 20:55:23 +0000 [thread overview]
Message-ID: <87tuql7ygu.fsf@linaro.org> (raw)
In-Reply-To: <20210208113428.7181-1-peter.maydell@linaro.org>
Peter Maydell <peter.maydell@linaro.org> writes:
> We used to make a distinction between 'float64'/'float32' types and
> the 'uint64_t'/'uint32_t' types, requiring special conversion
> operations to go between them. We've now dropped this distinction as
> unnecessary, and the 'float*' types remain primarily for
> documentation purposes when used in places like the function
> prototypes of TCG helper functions.
>
> This means that there's no need for special gdb_get_float64() and
> gdb_get_float32() functions to write float64 or float32 values to the
> GDB protocol buffer; we can just use gdb_get_reg64() and
> gdb_get_reg32().
>
> Similarly, for reading a value out of the GDB buffer into a float64
> or float32 we can use ldq_p() or ldl_p() and need not use ldfq_p()
> or ldfl_p().
>
> This patchseries drops the use of the gdb_get_float* and ldf*
> functions from the three targets that were using them, and then
> removes the now-unused functions from gdbstub.h and bswap.h.
Queued to gdbstub/next, thanks.
--
Alex Bennée
prev parent reply other threads:[~2021-02-09 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 11:34 [PATCH 0/5] Drop float32/float64 accessors used by gdbstub code Peter Maydell
2021-02-08 11:34 ` [PATCH 1/5] target/sh4: Drop use of gdb_get_float32() and ldfl_p() Peter Maydell
2021-02-08 11:34 ` [PATCH 2/5] target/m68k: Drop use of gdb_get_float64() and ldfq_p() Peter Maydell
2021-02-09 19:41 ` Laurent Vivier
2021-02-08 11:34 ` [PATCH 3/5] target/ppc: " Peter Maydell
2021-02-09 5:10 ` David Gibson
2021-02-08 11:34 ` [PATCH 4/5] gdbstub: Remove unused gdb_get_float32() and gdb_get_float64() Peter Maydell
2021-02-08 11:34 ` [PATCH 5/5] bswap.h: Remove unused float-access functions Peter Maydell
2021-02-08 11:57 ` [PATCH 0/5] Drop float32/float64 accessors used by gdbstub code Philippe Mathieu-Daudé
2021-02-09 20:55 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuql7ygu.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).