From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-devel@nongnu.org, "Claudio Fontana" <cfontana@suse.de>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] softmmu: Add missing trace-events file
Date: Thu, 06 Aug 2020 16:16:17 +0200 [thread overview]
Message-ID: <87tuxf6ery.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <8a260e67-2bae-17d7-d34c-239df1c5eb5c@redhat.com> ("Philippe Mathieu-Daudé"'s message of "Wed, 5 Aug 2020 15:57:25 +0200")
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 8/5/20 3:27 PM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>>> Commit c7f419f584 moved softmmu-only files out of the root
>>> directory, but forgot to move the trace events, which should
>>> no longer be generated to "trace-root.h". Fix that by adding
>>> softmmu/trace-events.
>>
>> Dang! I'd like to have this in 5.1 if at all possible.
>>
> [...]
>>
>> scripts/cleanup-trace-events.pl finds these (and corrects them in-place,
>> which is not what we want here). It finds a few more. I'll look more
>> closely and report back.
>
> Congratulation, you just found the first job you'll add to our GitLab CI
> =)
cleanup-trace-events.pl is not fit for use in CI; see the list of
funnies in "[PATCH 4/4] trace-events: Fix attribution of trace points to
source". Perhaps it could be sufficiently improved.
next prev parent reply other threads:[~2020-08-06 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 13:02 [PATCH] softmmu: Add missing trace-events file Philippe Mathieu-Daudé
2020-08-05 13:27 ` Markus Armbruster
2020-08-05 13:57 ` Philippe Mathieu-Daudé
2020-08-06 14:16 ` Markus Armbruster [this message]
2020-08-06 14:21 ` Paolo Bonzini
2020-08-06 14:24 ` Claudio Fontana
2020-08-06 15:10 ` Philippe Mathieu-Daudé
2020-08-06 15:10 ` Markus Armbruster
2020-08-05 13:53 ` Claudio Fontana
2020-08-12 19:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuxf6ery.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=david@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).