From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brLPa-0005lF-SI
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 04:49:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brLPV-0006HD-TL
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 04:49:17 -0400
Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:37931)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brLPV-0006Gw-N7
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 04:49:13 -0400
Received: by mail-wm0-x229.google.com with SMTP id p138so198448788wmb.1
	for <qemu-devel@nongnu.org>; Tue, 04 Oct 2016 01:49:13 -0700 (PDT)
References: <1474048017-26696-1-git-send-email-rth@twiddle.net>
	<1474048017-26696-11-git-send-email-rth@twiddle.net>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1474048017-26696-11-git-send-email-rth@twiddle.net>
Date: Tue, 04 Oct 2016 09:49:10 +0100
Message-ID: <87twcssdmh.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 10/35] cputlb: Remove includes from
 softmmu_template.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org


Richard Henderson <rth@twiddle.net> writes:

> We already include exec/address-spaces.h and exec/memory.h in
> cputlb.c; the include of qemu/timer.h appears to be a fossil.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  softmmu_template.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/softmmu_template.h b/softmmu_template.h
> index 538cff5..b9532a4 100644
> --- a/softmmu_template.h
> +++ b/softmmu_template.h
> @@ -21,10 +21,6 @@
>   * You should have received a copy of the GNU Lesser General Public
>   * License along with this library; if not, see <http://www.gnu.org/licenses/>.
>   */
> -#include "qemu/timer.h"
> -#include "exec/address-spaces.h"
> -#include "exec/memory.h"
> -
>  #if DATA_SIZE == 8
>  #define SUFFIX q
>  #define LSUFFIX q


--
Alex Bennée