From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55525)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bkAjU-0000AQ-Et
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:00:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bkAjN-0003K5-Fi
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:00:11 -0400
Received: from mail-lf0-f43.google.com ([209.85.215.43]:36759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bkAjM-0003Jc-6F
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:00:05 -0400
Received: by mail-lf0-f43.google.com with SMTP id g62so10706372lfe.3
	for <qemu-devel@nongnu.org>; Wed, 14 Sep 2016 07:00:03 -0700 (PDT)
References: <1473244183-31510-1-git-send-email-david@gibson.dropbear.id.au>
	<1473244183-31510-55-git-send-email-david@gibson.dropbear.id.au>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1473244183-31510-55-git-send-email-david@gibson.dropbear.id.au>
Date: Wed, 14 Sep 2016 14:59:01 +0100
Message-ID: <87twdiinve.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PULL 54/64] hw/ppc: add a
 ppc_create_page_sizes_prop() helper routine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: peter.maydell@linaro.org, lvivier@redhat.com, thuth@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, =?utf-8?Q?C?= =?utf-8?Q?=C3=A9dric?= Le Goater <clg@kaod.org>


David Gibson <david@gibson.dropbear.id.au> writes:

> From: Cédric Le Goater <clg@kaod.org>
>
> The exact same routine will be used in PowerNV.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

This patch has broken 32 bit x86 builds on CentOS6 (I happened to be looking
at something else and found it broken):

    14:57 alex@centos6-x86/i686  [qemu.git/bisect:???] >make
      CC    ppc-softmmu/hw/ppc/fdt.o
    In file included from /home/alex/lsrc/qemu.git/hw/ppc/fdt.c:14:
    /home/alex/lsrc/qemu.git/include/hw/ppc/fdt.h:15: error: redefinition of typedef ‘CPUPPCState’
    /home/alex/lsrc/qemu.git/target-ppc/cpu-qom.h:41: note: previous declaration of ‘CPUPPCState’ was here
    make[1]: *** [hw/ppc/fdt.o] Error 1
    make: *** [subdir-ppc-softmmu] Error 2

--
Alex Bennée