From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alcyH-0000gu-54 for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:49:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alcyB-0003B8-GB for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:49:13 -0400 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alcyB-0003B2-8b for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:49:07 -0400 Received: by mail-wm0-x22c.google.com with SMTP id 127so135056831wmu.1 for ; Thu, 31 Mar 2016 06:49:06 -0700 (PDT) References: <1459280892-8789-1-git-send-email-sergey.fedorov@linaro.org> <1459280892-8789-2-git-send-email-sergey.fedorov@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1459280892-8789-2-git-send-email-sergey.fedorov@linaro.org> Date: Thu, 31 Mar 2016 14:49:08 +0100 Message-ID: <87twjmg3l7.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 1/3] tcg: code_bitmap is not used by user-mode emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov Cc: Sergey Fedorov , Richard Henderson , Peter Crosthwaite , qemu-devel@nongnu.org, Paolo Bonzini Sergey Fedorov writes: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > [Sergey Fedorov: eliminate the field entirely in user-mode] > Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée > --- > > Notes: > Changes in v2: > * The field is eliminated entirely in user-mode > > translate-all.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index e9f409b762ab..c131ce2f183e 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -75,8 +75,9 @@ typedef struct PageDesc { > /* in order to optimize self modifying code, we count the number > of lookups we do to a given page to use a bitmap */ > unsigned int code_write_count; > +#ifdef CONFIG_SOFTMMU > unsigned long *code_bitmap; > -#if defined(CONFIG_USER_ONLY) > +#else > unsigned long flags; > #endif > } PageDesc; > @@ -784,8 +785,10 @@ void tb_free(TranslationBlock *tb) > > static inline void invalidate_page_bitmap(PageDesc *p) > { > +#ifdef CONFIG_SOFTMMU > g_free(p->code_bitmap); > p->code_bitmap = NULL; > +#endif > p->code_write_count = 0; > } > > @@ -1018,6 +1021,7 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) > tcg_ctx.tb_ctx.tb_phys_invalidate_count++; > } > > +#ifdef CONFIG_SOFTMMU > static void build_page_bitmap(PageDesc *p) > { > int n, tb_start, tb_end; > @@ -1046,6 +1050,7 @@ static void build_page_bitmap(PageDesc *p) > tb = tb->page_next[n]; > } > } > +#endif > > /* Called with mmap_lock held for user mode emulation. */ > TranslationBlock *tb_gen_code(CPUState *cpu, > @@ -1294,6 +1299,7 @@ void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end, > #endif > } > > +#ifdef CONFIG_SOFTMMU > /* len must be <= 8 and start must be a multiple of len */ > void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len) > { > @@ -1331,8 +1337,7 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len) > tb_invalidate_phys_page_range(start, start + len, 1); > } > } > - > -#if !defined(CONFIG_SOFTMMU) > +#else > /* Called with mmap_lock held. */ > static void tb_invalidate_phys_page(tb_page_addr_t addr, > uintptr_t pc, void *puc, -- Alex Bennée