From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZziuB-0007WP-Rg for qemu-devel@nongnu.org; Fri, 20 Nov 2015 05:27:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zziu8-0001nc-NW for qemu-devel@nongnu.org; Fri, 20 Nov 2015 05:26:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zziu8-0001nY-Hp for qemu-devel@nongnu.org; Fri, 20 Nov 2015 05:26:56 -0500 From: Juan Quintela In-Reply-To: <1447946868-11670-1-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 19 Nov 2015 15:27:48 +0000") References: <1447946868-11670-1-git-send-email-dgilbert@redhat.com> Date: Fri, 20 Nov 2015 11:26:33 +0100 Message-ID: <87twohx8yu.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: amit.shah@redhat.com, borntraeger@de.ibm.com, qemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > madvise() returns EINVAL in the case of many failures, but also > returns it in cases where the host kernel doesn't have THP enabled. > Postcopy only really cares that THP is off before it detects faults, > and turns it back on afterwards; so we're going to have > to assume that if the madvise fails then the host just doesn't do > THP and we can carry on with the postcopy. > > Signed-off-by: Dr. David Alan Gilbert > Tested-by: Jason J. Herne Reviewed-by: Juan Quintela