From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEg0A-0000WR-Sf for qemu-devel@nongnu.org; Mon, 13 Jul 2015 11:50:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEg04-00055V-UV for qemu-devel@nongnu.org; Mon, 13 Jul 2015 11:50:42 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:36651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEg04-00054m-PO for qemu-devel@nongnu.org; Mon, 13 Jul 2015 11:50:36 -0400 Received: by widjy10 with SMTP id jy10so73646424wid.1 for ; Mon, 13 Jul 2015 08:50:35 -0700 (PDT) References: <1436544486-31169-1-git-send-email-fred.konrad@greensocs.com> <55A3A6CB.2040104@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <55A3A6CB.2040104@redhat.com> Date: Mon, 13 Jul 2015 16:50:32 +0100 Message-ID: <87twt8jbuf.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V2 0/3] Multithread TCG async_safe_work part. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: mttcg@greensocs.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, fred.konrad@greensocs.com Paolo Bonzini writes: > On 10/07/2015 18:08, fred.konrad@greensocs.com wrote: >> From: KONRAD Frederic >> >> This is the async_safe_work introduction bit of the Multithread TCG work. >> Rebased on current upstream (6169b60285fe1ff730d840a49527e721bfb30899). >> >> It can be cloned here: >> http://git.greensocs.com/fkonrad/mttcg.git branch async_work_v2 >> >> The first patch introduces a mutex to protect the existing queued_work_* >> CPUState members against multiple (concurent) access. >> >> The second patch introduces a tcg_executing_flag which will be 1 when we are >> inside cpu_exec(). This is required as safe work need to be sure that's all vCPU >> are outside cpu_exec(). >> >> The last patch introduces async_safe_work. It allows to add some work which will >> be done asynchronously but only when all vCPUs are outside cpu_exec(). The tcg >> thread will wait that no vCPUs have any pending safe work before reentering >> cpu-exec(). >> >> Changes V1 -> V2: >> * Release the lock while running the callback for both async and safe work. > > What tree do these patches apply to? See Fred's tree: http://git.greensocs.com/fkonrad/mttcg > > Paolo > >> KONRAD Frederic (3): >> cpus: protect queued_work_* with work_mutex. >> cpus: add a tcg_executing flag. >> cpus: introduce async_run_safe_work_on_cpu. >> >> cpu-exec.c | 7 +++ >> cpus.c | 164 +++++++++++++++++++++++++++++++++++++++++------------- >> include/qom/cpu.h | 28 ++++++++++ >> qom/cpu.c | 2 + >> 4 files changed, 161 insertions(+), 40 deletions(-) >> -- Alex Bennée