From: "Alex Bennée" <alex.bennee@linaro.org>
To: Greg Bellows <greg.bellows@linaro.org>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [PATCH v1 01/15] android-console: Fix goldfish audio misnaming
Date: Thu, 13 Nov 2014 10:01:56 +0000 [thread overview]
Message-ID: <87tx23h10r.fsf@linaro.org> (raw)
In-Reply-To: <1415751963-4081-2-git-send-email-greg.bellows@linaro.org>
Greg Bellows <greg.bellows@linaro.org> writes:
> Replaced goldfish_audio misnaming to goldfish_battery where appropriate in
> goldfish_battery.c
Ahh good 'ole copy pasta bugs ;-)
This will probably be worth squash merging when we clean-up the tree.
>
> Signed-off-by: Greg Bellows <greg.bellows@linaro.org>
> ---
> hw/misc/goldfish_battery.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/misc/goldfish_battery.c b/hw/misc/goldfish_battery.c
> index 03847d6..89fd05d 100644
> --- a/hw/misc/goldfish_battery.c
> +++ b/hw/misc/goldfish_battery.c
> @@ -121,7 +121,7 @@ static void goldfish_battery_write(void *opaque, hwaddr offset, uint64_t val,
> break;
>
> default:
> - error_report ("goldfish_audio_write: Bad offset " TARGET_FMT_plx,
> + error_report("goldfish_battery_write: Bad offset " TARGET_FMT_plx,
> offset);
> }
> }
> @@ -161,16 +161,16 @@ static void goldfish_battery_class_init(ObjectClass *klass, void *data)
> dc->desc = "goldfish battery";
> }
>
> -static const TypeInfo goldfish_audio_info = {
> +static const TypeInfo goldfish_battery_info = {
> .name = TYPE_GOLDFISH_BATTERY,
> .parent = TYPE_SYS_BUS_DEVICE,
> .instance_size = sizeof(struct goldfish_battery_state),
> .class_init = goldfish_battery_class_init,
> };
>
> -static void goldfish_audio_register(void)
> +static void goldfish_battery_register(void)
> {
> - type_register_static(&goldfish_audio_info);
> + type_register_static(&goldfish_battery_info);
> }
>
> -type_init(goldfish_audio_register);
> +type_init(goldfish_battery_register);
--
Alex Bennée
next prev parent reply other threads:[~2014-11-13 10:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 0:25 [Qemu-devel] [PATCH v1 00/15] android-console: Add console power command Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 01/15] android-console: Fix goldfish audio misnaming Greg Bellows
2014-11-13 10:01 ` Alex Bennée [this message]
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 02/15] android-console: Unify available commands output Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 03/15] android-console: Remove extra redir help message Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 04/15] android-console: Consolidate redir help text Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 05/15] android-console: Add console base power command Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 06/15] android-console: Add missing hw_has_battery prop Greg Bellows
2014-11-13 10:03 ` Alex Bennée
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID state field Greg Bellows
2014-11-13 10:05 ` Alex Bennée
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 08/15] android-console: Add header for battery externs Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 09/15] android-console: Add GF battery prop print func Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 10/15] android-console: Add GF battery property getter Greg Bellows
2014-11-12 0:25 ` [Qemu-devel] [PATCH v1 11/15] android-console: Add power ac command Greg Bellows
2014-11-12 0:26 ` [Qemu-devel] [PATCH v1 12/15] android-console: Add power status command Greg Bellows
2014-11-12 0:26 ` [Qemu-devel] [PATCH v1 13/15] android-console: Add power present command Greg Bellows
2014-11-12 0:26 ` [Qemu-devel] [PATCH v1 14/15] android-console: Add power health command Greg Bellows
2014-11-12 0:26 ` [Qemu-devel] [PATCH v1 15/15] android-console: Add power capacity command Greg Bellows
2014-11-13 10:17 ` Alex Bennée
2014-11-12 13:39 ` [Qemu-devel] [PATCH v1 00/15] android-console: Add console power command Greg Bellows
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx23h10r.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=greg.bellows@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).