From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKZ4v-0008J5-3Z for qemu-devel@nongnu.org; Mon, 03 Mar 2014 15:03:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKZ4m-0002Yn-7U for qemu-devel@nongnu.org; Mon, 03 Mar 2014 15:03:09 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:43542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKZ4l-0002YY-Gr for qemu-devel@nongnu.org; Mon, 03 Mar 2014 15:03:00 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Mar 2014 06:02:56 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 9737F357803F for ; Tue, 4 Mar 2014 07:02:52 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s23K2cIw6423012 for ; Tue, 4 Mar 2014 07:02:38 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s23K2pqn019467 for ; Tue, 4 Mar 2014 07:02:51 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <87y50rvzkw.fsf@linux.vnet.ibm.com> References: <1393873716-9574-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <5314D475.8070107@redhat.com> <87y50rvzkw.fsf@linux.vnet.ibm.com> Date: Tue, 04 Mar 2014 01:32:48 +0530 Message-ID: <87txbfvymv.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, Fam Zheng "Aneesh Kumar K.V" writes: > Paolo Bonzini writes: > >> Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: >>> From: "Aneesh Kumar K.V" >>> >>> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including >>> hw/Makefile.objs directly from Makefile.target. Hence we need to define >>> the config in Makefile.target too to include virtio-9p-device.o in >>> the build >>> >>> Signed-off-by: Aneesh Kumar K.V >>> --- >>> Makefile.target | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Makefile.target b/Makefile.target >>> index ba1234063eae..da8daa82c39e 100644 >>> --- a/Makefile.target >>> +++ b/Makefile.target >>> @@ -137,6 +137,10 @@ endif # CONFIG_SOFTMMU >>> # Workaround for http://gcc.gnu.org/PR55489, see configure. >>> %/translate.o: QEMU_CFLAGS += $(TRANSLATE_OPT_CFLAGS) >>> >>> +ifeq ($(CONFIG_VIRTIO)$(CONFIG_VIRTFS)$(CONFIG_PCI),yyy) >>> +CONFIG_REALLY_VIRTFS=y >>> +endif >>> + >>> dummy := $(call unnest-vars,,obj-y) >>> >>> # we are making another call to unnest-vars with different vars, protect obj-y, >>> >> >> Can you just replace $(CONFIG_REALLY_VIRTFS) with >> >> $(call land, $(call land, $(CONFIG_VIRTIO), >> $(CONFIG_VIRTFS)), >> $(CONFIG_PCI)) >> >> in hw/Makefile.objs, and remove it from Makefile.objs? > > Like this ? That worked. Will update the patch > > -devices-dirs-$(CONFIG_REALLY_VIRTFS) += 9pfs/ > +devices-dirs-($call > land,$(CONFIG_VIRTIO),$(CONFIG_VIRTFS),$(CONFIG_PCI)) += 9pfs/ That didn't really work with your suggested change i get rules.mak:190: *** unterminated call to function `call': missing `)'. Stop -aneesh