From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>,
"qemu-ppc@nongnu.org list:PowerPC" <qemu-ppc@nongnu.org>,
"qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled
Date: Mon, 26 Aug 2013 09:03:42 +0530 [thread overview]
Message-ID: <87txiddt2h.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1377465202.3819.25.camel@pasglop>
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Sun, 2013-08-25 at 19:32 +0100, Alexander Graf wrote:
>> > + * At this point we are only interested in reading only bolted
>> entries
>> > + */
>> > + ghf.flags = KVM_GET_HTAB_BOLTED_ONLY;
>> > + ghf.start_index = index;
>> > + htab_fd = kvm_vm_ioctl(kvm_state, KVM_PPC_GET_HTAB_FD, &ghf);
>>
>> We should cache this.
>>
> Also why bolted only ?
because non bolted entries could be invalidated and reused by the time
we look at the returned hpte values. I am not sure, whether it is ok or
we need to make sure such a thing doesn't happen. For the use case i am
looking at, ie, to dump the kernel address looking at bolted entries was
enough.
-aneesh
next prev parent reply other threads:[~2013-08-26 3:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1377235210-27093-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
[not found] ` <1377235210-27093-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:32 ` [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values Alexander Graf
2013-08-26 6:46 ` Aneesh Kumar K.V
2013-08-26 10:31 ` Alexander Graf
2013-08-26 12:16 ` Aneesh Kumar K.V
[not found] ` <1377235210-27093-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:32 ` [Qemu-devel] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled Alexander Graf
2013-08-25 21:13 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-08-26 3:33 ` Aneesh Kumar K.V [this message]
2013-08-26 3:45 ` Benjamin Herrenschmidt
2013-08-26 5:46 ` [Qemu-devel] " Aneesh Kumar K.V
2013-08-26 11:09 ` Alexander Graf
2013-08-26 12:18 ` Aneesh Kumar K.V
[not found] ` <1377235210-27093-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:32 ` [Qemu-devel] [PATCH -V3 3/4] target-ppc: Check for error on address translation in memsave command Alexander Graf
2013-08-25 22:17 ` Andreas Färber
2013-08-26 12:20 ` Aneesh Kumar K.V
2013-08-26 12:22 ` Andreas Färber
2013-08-26 13:22 ` Luiz Capitulino
[not found] ` <1377235210-27093-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:33 ` [Qemu-devel] [PATCH -V3 4/4] target-ppc: Use #define for max slb entries Alexander Graf
2013-08-25 22:20 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txiddt2h.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).