From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFr5b-0002PI-Az for qemu-devel@nongnu.org; Wed, 13 Mar 2013 15:11:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFr5Z-00039Q-JT for qemu-devel@nongnu.org; Wed, 13 Mar 2013 15:11:51 -0400 Received: from mail-ye0-f179.google.com ([209.85.213.179]:62678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFr5Z-00039F-GA for qemu-devel@nongnu.org; Wed, 13 Mar 2013 15:11:49 -0400 Received: by mail-ye0-f179.google.com with SMTP id r1so240170yen.24 for ; Wed, 13 Mar 2013 12:11:48 -0700 (PDT) From: Anthony Liguori In-Reply-To: <1363200988-17865-3-git-send-email-jschopp@linux.vnet.ibm.com> References: <1363200988-17865-1-git-send-email-jschopp@linux.vnet.ibm.com> <1363200988-17865-3-git-send-email-jschopp@linux.vnet.ibm.com> Date: Wed, 13 Mar 2013 14:11:46 -0500 Message-ID: <87txof5d3h.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 2/9] qapi_c_arrays.diff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Schopp , qemu-devel@nongnu.org Cc: Michael Tsirkin , Michael Roth , Paolo Bonzini You need to adjust your patch script. This will make the summary in git be: qapi_c_arrays.gdiff Forward ported Mike's previously sent patch (see http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05782.html ) ... Regards, Anthony Liguori Joel Schopp writes: > Forward ported Mike's previously sent patch > (see http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05782.html ) in my > series since it implements a qapi array interface the ASN.1 BER visitor needs. > > Generally these will be serialized into lists, but the > representation can be of any form so long as it can > be deserialized into a single-dimension C array. > > Cc: Michael Tsirkin > Cc: Paolo Bonzini > Signed-off-by: Michael Roth > Signed-off-by: Joel Schopp > --- > include/qapi/visitor-impl.h | 4 ++++ > include/qapi/visitor.h | 4 ++++ > qapi/qapi-visit-core.c | 25 +++++++++++++++++++++++++ > 3 files changed, 33 insertions(+) > > diff --git a/include/qapi/visitor-impl.h b/include/qapi/visitor-impl.h > index 5159964..9d87f2d 100644 > --- a/include/qapi/visitor-impl.h > +++ b/include/qapi/visitor-impl.h > @@ -34,6 +34,10 @@ struct Visitor > void (*type_str)(Visitor *v, char **obj, const char *name, Error **errp); > void (*type_number)(Visitor *v, double *obj, const char *name, > Error **errp); > + void (*start_carray)(Visitor *v, void **obj, const char *name, > + size_t elem_count, size_t elem_size, Error **errp); > + void (*next_carray)(Visitor *v, Error **errp); > + void (*end_carray)(Visitor *v, Error **errp); > > /* May be NULL */ > void (*start_optional)(Visitor *v, bool *present, const char *name, > diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h > index 1fef18c..74bddef 100644 > --- a/include/qapi/visitor.h > +++ b/include/qapi/visitor.h > @@ -51,5 +51,9 @@ void visit_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp); > void visit_type_bool(Visitor *v, bool *obj, const char *name, Error **errp); > void visit_type_str(Visitor *v, char **obj, const char *name, Error **errp); > void visit_type_number(Visitor *v, double *obj, const char *name, Error **errp); > +void visit_start_carray(Visitor *v, void **obj, const char *name, > + size_t elem_count, size_t elem_size, Error **errp); > +void visit_next_carray(Visitor *v, Error **errp); > +void visit_end_carray(Visitor *v, Error **errp); > > #endif > diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c > index 401ee6e..d9982f8 100644 > --- a/qapi/qapi-visit-core.c > +++ b/qapi/qapi-visit-core.c > @@ -313,3 +313,28 @@ void input_type_enum(Visitor *v, int *obj, const char *strings[], > g_free(enum_str); > *obj = value; > } > + > +void visit_start_carray(Visitor *v, void **obj, const char *name, > + size_t elem_count, size_t elem_size, Error **errp) > +{ > + g_assert(v->start_carray); > + if (!error_is_set(errp)) { > + v->start_carray(v, obj, name, elem_count, elem_size, errp); > + } > +} > + > +void visit_next_carray(Visitor *v, Error **errp) > +{ > + g_assert(v->next_carray); > + if (!error_is_set(errp)) { > + v->next_carray(v, errp); > + } > +} > + > +void visit_end_carray(Visitor *v, Error **errp) > +{ > + g_assert(v->end_carray); > + if (!error_is_set(errp)) { > + v->end_carray(v, errp); > + } > +} > -- > 1.7.10.4