From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDdvn-0002GH-81 for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:44:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDdvl-0001x9-DP for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:44:35 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:59203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDdvk-0001wl-SB for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:44:33 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Mar 2013 02:39:33 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id EA334357802D for ; Fri, 8 Mar 2013 03:44:25 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r27GVdxu524614 for ; Fri, 8 Mar 2013 03:31:39 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r27GiPl2016558 for ; Fri, 8 Mar 2013 03:44:25 +1100 From: Anthony Liguori In-Reply-To: <5138C26B.5010408@suse.de> References: <1360108037-9211-1-git-send-email-jlarrew@linux.vnet.ibm.com> <1360108037-9211-3-git-send-email-jlarrew@linux.vnet.ibm.com> <513621F7.9030403@suse.de> <51362575.2000908@de.ibm.com> <87621319kc.fsf@codemonkey.ws> <5138C007.6080305@de.ibm.com> <5138C26B.5010408@suse.de> Date: Thu, 07 Mar 2013 10:44:18 -0600 Message-ID: <87txon6ty5.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= , Christian Borntraeger Cc: Alexander Graf , "Michael S. Tsirkin" , Stefan Hajnoczi , Jesse Larrew , qemu-devel@nongnu.org, Jens Freimann , Cornelia Huck Andreas F=C3=A4rber writes: > Am 07.03.2013 17:27, schrieb Christian Borntraeger: >>> It's a bug in both virtio-ccw that features=3D0 when get_features is >>> called. You can also tell this with: >>> >>> [10:02 AM] anthony@titi:~/git/qemu/hw/s390x$ grep DEFINE_VIRTIO_NET_FEA= TURES * >>> virtio-ccw.c: DEFINE_VIRTIO_NET_FEATURES(VirtioCcwDevice, host_featu= res[0]), >>> >>> So virtio-s390 is doing it wrong, but virtio-ccw looks like its doing it >>> right. >>=20 >> At least, this patch seems to work. (That also implies, that a transport >> must not hide virtio feature bits). > > To me it indicates that the use of the old qdev property setters is > hiding errors resulting from trying to set not-existing properties. > If we would set the properties in a way that gets us an Error* on > failure like the object_property_set_*() do, we would notice on machine > creation (or device_add). Hrm, I don't understand your statement. Can you elaborate? Regards, Anthony Liguori > > Andreas > >>=20 >>=20 >> From: Christian Borntraeger >> Date: Thu, 7 Mar 2013 17:21:41 +0100 >> Subject: [PATCH] Allow virtio-net features for legacy s390 virtio bus >>=20 >> Enable all virtio-net features for the legacy s390 virtio bus. >> This also fixes >> kernel BUG at /usr/src/packages/BUILD/kernel-default-3.0.58/linux-3.0/dr= ivers/s390/kvm/kvm_virtio.c:121! >>=20 >> Signed-off-by: Christian Borntraeger >> --- >> hw/s390x/s390-virtio-bus.c | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c >> index 1200691..a8a8e19 100644 >> --- a/hw/s390x/s390-virtio-bus.c >> +++ b/hw/s390x/s390-virtio-bus.c >> @@ -399,6 +399,7 @@ static const VirtIOBindings virtio_s390_bindings =3D= { >>=20=20 >> static Property s390_virtio_net_properties[] =3D { >> DEFINE_NIC_PROPERTIES(VirtIOS390Device, nic), >> + DEFINE_VIRTIO_NET_FEATURES(VirtIOS390Device, host_features), >> DEFINE_PROP_UINT32("x-txtimer", VirtIOS390Device, >> net.txtimer, TX_TIMER_INTERVAL), >> DEFINE_PROP_INT32("x-txburst", VirtIOS390Device, >>=20 > > > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg