From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1Qil-0002NA-8f for qemu-devel@nongnu.org; Fri, 01 Feb 2013 19:12:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1Qij-0008DE-1Q for qemu-devel@nongnu.org; Fri, 01 Feb 2013 19:12:39 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:41130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1Qii-0008D6-U5 for qemu-devel@nongnu.org; Fri, 01 Feb 2013 19:12:36 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Feb 2013 19:12:36 -0500 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 344766E803A for ; Fri, 1 Feb 2013 19:12:23 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r120COdg225940 for ; Fri, 1 Feb 2013 19:12:24 -0500 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r120COZF029753 for ; Fri, 1 Feb 2013 22:12:24 -0200 From: Anthony Liguori In-Reply-To: <1359763709-17712-1-git-send-email-aliguori@us.ibm.com> References: <1359763709-17712-1-git-send-email-aliguori@us.ibm.com> Date: Fri, 01 Feb 2013 18:12:19 -0600 Message-ID: <87txpvr2u4.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jason Wang , Bruce Rogers Please ignore the 1/2 in the subject... a bit past beer time and I got a little sloppy sending this patch. Regards, Anthony Liguori Anthony Liguori writes: > The multiqueue patch series broke -netdev tap,fd=X which manifests > as libvirt not being able to start a guest. This was because it > passed NULL for the netdev name which results in an anonymous netdev > device regardless of what the user specified. > > Cc: Jason Wang > Cc: Bruce Rogers > Reported-by: Bruce Rogers > Signed-off-by: Anthony Liguori > --- > net/tap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/tap.c b/net/tap.c > index 1bf7609..48c254e 100644 > --- a/net/tap.c > +++ b/net/tap.c > @@ -711,7 +711,7 @@ int net_init_tap(const NetClientOptions *opts, const char *name, > > vnet_hdr = tap_probe_vnet_hdr(fd); > > - if (net_init_tap_one(tap, peer, "tap", NULL, NULL, > + if (net_init_tap_one(tap, peer, "tap", name, NULL, > script, downscript, > vhostfdname, vnet_hdr, fd)) { > return -1; > -- > 1.8.0