* [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X
@ 2013-02-02 0:08 Anthony Liguori
2013-02-02 0:12 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Anthony Liguori @ 2013-02-02 0:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, Jason Wang, Bruce Rogers
The multiqueue patch series broke -netdev tap,fd=X which manifests
as libvirt not being able to start a guest. This was because it
passed NULL for the netdev name which results in an anonymous netdev
device regardless of what the user specified.
Cc: Jason Wang <jasowang@redhat.com>
Cc: Bruce Rogers <brogers@suse.com>
Reported-by: Bruce Rogers <brogers@suse.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
net/tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tap.c b/net/tap.c
index 1bf7609..48c254e 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -711,7 +711,7 @@ int net_init_tap(const NetClientOptions *opts, const char *name,
vnet_hdr = tap_probe_vnet_hdr(fd);
- if (net_init_tap_one(tap, peer, "tap", NULL, NULL,
+ if (net_init_tap_one(tap, peer, "tap", name, NULL,
script, downscript,
vhostfdname, vnet_hdr, fd)) {
return -1;
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X
2013-02-02 0:08 [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X Anthony Liguori
@ 2013-02-02 0:12 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2013-02-02 0:12 UTC (permalink / raw)
To: qemu-devel; +Cc: Jason Wang, Bruce Rogers
Please ignore the 1/2 in the subject... a bit past beer time and I got
a little sloppy sending this patch.
Regards,
Anthony Liguori
Anthony Liguori <aliguori@us.ibm.com> writes:
> The multiqueue patch series broke -netdev tap,fd=X which manifests
> as libvirt not being able to start a guest. This was because it
> passed NULL for the netdev name which results in an anonymous netdev
> device regardless of what the user specified.
>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Bruce Rogers <brogers@suse.com>
> Reported-by: Bruce Rogers <brogers@suse.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> net/tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tap.c b/net/tap.c
> index 1bf7609..48c254e 100644
> --- a/net/tap.c
> +++ b/net/tap.c
> @@ -711,7 +711,7 @@ int net_init_tap(const NetClientOptions *opts, const char *name,
>
> vnet_hdr = tap_probe_vnet_hdr(fd);
>
> - if (net_init_tap_one(tap, peer, "tap", NULL, NULL,
> + if (net_init_tap_one(tap, peer, "tap", name, NULL,
> script, downscript,
> vhostfdname, vnet_hdr, fd)) {
> return -1;
> --
> 1.8.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-02 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-02 0:08 [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X Anthony Liguori
2013-02-02 0:12 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).