From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QF7ew-00085R-D2 for qemu-devel@nongnu.org; Wed, 27 Apr 2011 12:32:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QF7ev-0003yC-Gp for qemu-devel@nongnu.org; Wed, 27 Apr 2011 12:32:14 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:37864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QF7eu-0003xn-TK for qemu-devel@nongnu.org; Wed, 27 Apr 2011 12:32:13 -0400 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247]) by e23smtp09.au.ibm.com (8.14.4/8.13.1) with ESMTP id p3RGVwP5021870 for ; Thu, 28 Apr 2011 02:31:58 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p3RGVt3S1437938 for ; Thu, 28 Apr 2011 02:31:57 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3RGVtKb030203 for ; Thu, 28 Apr 2011 02:31:55 +1000 From: "Aneesh Kumar K.V" In-Reply-To: <4DB83CFC.4000800@linux.vnet.ibm.com> References: <1303887233-6668-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <4DB7BFDC.6050801@web.de> <874o5kx9uk.fsf@linux.vnet.ibm.com> <4DB83CFC.4000800@linux.vnet.ibm.com> Date: Wed, 27 Apr 2011 22:01:51 +0530 Message-ID: <87tydjwt8o.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] virtio-9p: move 9p files around List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Venkateswararao Jujjuri , qemu-devel@nongnu.org On Wed, 27 Apr 2011 08:57:48 -0700, Venkateswararao Jujjuri wrote: > On 04/27/2011 03:33 AM, Aneesh Kumar K.V wrote: > > On Wed, 27 Apr 2011 09:03:56 +0200, Jan Kiszka wrote: > >> On 2011-04-27 08:53, Aneesh Kumar K.V wrote: > >>> Now that we start adding more files related to 9pfs > >>> it make sense to move them to a separate directory > >>> > >>> Signed-off-by: Aneesh Kumar K.V > >>> --- > >>> Makefile.objs | 10 +++++++--- > >>> Makefile.target | 6 ++++-- > >>> configure | 2 ++ > >>> {hw => fsdev}/file-op-9p.h | 0 > >>> fsdev/qemu-fsdev.h | 2 +- > >>> hw/{ => 9pfs}/virtio-9p-debug.c | 0 > >>> hw/{ => 9pfs}/virtio-9p-debug.h | 0 > >>> hw/{ => 9pfs}/virtio-9p-local.c | 0 > >>> hw/{ => 9pfs}/virtio-9p-posix-acl.c | 2 +- > >>> hw/{ => 9pfs}/virtio-9p-xattr-user.c | 2 +- > >>> hw/{ => 9pfs}/virtio-9p-xattr.c | 2 +- > >>> hw/{ => 9pfs}/virtio-9p-xattr.h | 0 > >>> hw/{ => 9pfs}/virtio-9p.c | 0 > >>> hw/{ => 9pfs}/virtio-9p.h | 2 +- > >>> 14 files changed, 18 insertions(+), 10 deletions(-) > >>> rename {hw => fsdev}/file-op-9p.h (100%) > >>> rename hw/{ => 9pfs}/virtio-9p-debug.c (100%) > >>> rename hw/{ => 9pfs}/virtio-9p-debug.h (100%) > >>> rename hw/{ => 9pfs}/virtio-9p-local.c (100%) > >>> rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (99%) > >>> rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%) > >>> rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%) > >>> rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%) > >>> rename hw/{ => 9pfs}/virtio-9p.c (100%) > >> That's a good chance to split up this file, move virtio_9p_get_config > >> into a separate one and build the large virtio-9p.c as part of hwlib > >> while keeping the new file target-specific. I've some hack for this > >> lying around, but now that you are already at it... > >> > > How about doing the below patch also and move all those device specific > > stuff to virtio-9p-device.c and rest in virtio-9p.c ? > I think this goes on top of your old patch. I am ready to give pull to > Anthony with old patch. > May be this can go in next pull? > Yes the two new patches can go later -aneesh