Re: g_autoptr(Error)

[Markus Armbruster <armbru@redhat.com>]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Wed, Nov 26, 2025 at 12:46:40PM +0100, Markus Armbruster wrote:

[...]

>> Don't worry about it!  From my point of view, the process worked okay.
>> A big series got reviewed by maintainers, except for one little patch
>> touching another subsystem, where that subsystem's maintainer (me)
>> remained silent.  The series was then merged without further delay.
>> 
>> Would I have appreciate a timely nudge on that little patch?  Sure.  Is
>> not nudging me a failure of sorts?  Nope.
>
> The other thing that plays in here is that we actively encourage use of
> g_autoptr everywhere.

We do, and for good reasons.

>                       It is very unusual for "Error" to be a type that
> does NOT want g_autoptr, and thus the mistake is very much on the cards.
>
> I've proposed it before myself & Markus caught it. I also caught one
> other proposals to add it since my attempt. This third time it slipped
> through review. I expect we'll see a 4th attempt to add it at some point.

%-}