From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED1B2CCD1BB for ; Wed, 22 Oct 2025 14:09:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBZWZ-0002N5-JC; Wed, 22 Oct 2025 10:09:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBZWU-0002Ma-JO for qemu-devel@nongnu.org; Wed, 22 Oct 2025 10:09:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBZWO-0002av-3B for qemu-devel@nongnu.org; Wed, 22 Oct 2025 10:09:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761142138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+vDjnzrbU8LrYUNj3f7aSg/oxvbRwX7zoBUf1/4p4yY=; b=Z9uZxZ8vSNaBTbz8lFawMEYW0UliprF/iB0dNRMuQkio8tTQ3Xn7TxVPQJlPEMV7qLewWM 2jTom5BiBz3W19fN6lhB+WgNzDYtGWKPix/q+sN/9gvyigc6IrZWttMerpdt0RzqAtOHIr hlQAEqlaKAgnUm8GBlxlciOZ0GXp+Zc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-Lt24Ry_vPVqgsW-txqARig-1; Wed, 22 Oct 2025 10:08:50 -0400 X-MC-Unique: Lt24Ry_vPVqgsW-txqARig-1 X-Mimecast-MFC-AGG-ID: Lt24Ry_vPVqgsW-txqARig_1761142129 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DF40518002DD; Wed, 22 Oct 2025 14:08:48 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.19]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 69D2C300019F; Wed, 22 Oct 2025 14:08:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B267021E6A27; Wed, 22 Oct 2025 16:08:45 +0200 (CEST) From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net, philmd@linaro.org Subject: Re: [PATCH 1/3] qdev: Change PropertyInfo method print() to return malloc'ed string In-Reply-To: (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Wed, 22 Oct 2025 14:59:57 +0400") References: <20251022101420.36059-1-armbru@redhat.com> <20251022101420.36059-2-armbru@redhat.com> Date: Wed, 22 Oct 2025 16:08:45 +0200 Message-ID: <87v7k7c9le.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Marc-Andr=C3=A9 Lureau writes: > Hi > > On Wed, Oct 22, 2025 at 2:15=E2=80=AFPM Markus Armbruster wrote: >> >> Simpler (more so after the next commit), and no risk of truncation >> because the caller's buffer is too small. Performance doesn't matter; >> the method is only used for "info qdev". >> >> Signed-off-by: Markus Armbruster [...] >> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c >> index b7e8a89ba5..422a486969 100644 >> --- a/hw/core/qdev-properties.c >> +++ b/hw/core/qdev-properties.c >> @@ -1117,12 +1117,11 @@ static void qdev_get_legacy_property(Object *obj= , Visitor *v, >> Error **errp) >> { >> const Property *prop =3D opaque; >> + char *s; > > Why not g_autofree ? Old habits... I think it's a wash here, because there's just one path through the function. >> - char buffer[1024]; >> - char *ptr =3D buffer; >> - >> - prop->info->print(obj, prop, buffer, sizeof(buffer)); >> - visit_type_str(v, name, &ptr, errp); >> + s =3D prop->info->print(obj, prop); >> + visit_type_str(v, name, &s, errp); >> + g_free(s); > > otherwise, > Reviewed-by: Marc-Andr=C3=A9 Lureau Thanks!