From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94E0AC36000 for ; Fri, 21 Mar 2025 15:30:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tveJc-0005cS-GZ; Fri, 21 Mar 2025 11:29:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tveJW-0005af-KF for qemu-devel@nongnu.org; Fri, 21 Mar 2025 11:29:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tveJS-0003jT-9v for qemu-devel@nongnu.org; Fri, 21 Mar 2025 11:29:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742570971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4tZTzGgPKruPQVAWMAtbqY5MZg/vcSrQFesspSXYw08=; b=fjevIMUVy3jnqTeBQ+qywsKZRr/Q92dNTZtFAEF+q8KHYHuok/nADGBtizVo+OQYOjBOk4 sHn1HB9XnalX61yvdFkzq3W6jYbewRBa09CZQcdZeQqILytGLDAWFiu44f9xB2w2LjFbf4 GtzTSHY8RZC3vR6FlZUC2q2A9b40nls= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-z9XOUjvyPIWnnUBBdnLNDg-1; Fri, 21 Mar 2025 11:29:26 -0400 X-MC-Unique: z9XOUjvyPIWnnUBBdnLNDg-1 X-Mimecast-MFC-AGG-ID: z9XOUjvyPIWnnUBBdnLNDg_1742570965 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CAD31180AF50; Fri, 21 Mar 2025 15:29:23 +0000 (UTC) Received: from localhost (unknown [10.67.24.51]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C0541954B04; Fri, 21 Mar 2025 15:29:19 +0000 (UTC) From: Cornelia Huck To: Sebastian Ott Cc: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvmarm@lists.linux.dev, peter.maydell@linaro.org, richard.henderson@linaro.org, alex.bennee@linaro.org, maz@kernel.org, oliver.upton@linux.dev, shameerali.kolothum.thodi@huawei.com, armbru@redhat.com, berrange@redhat.com, abologna@redhat.com, jdenemar@redhat.com, agraf@csgraf.de, shahuang@redhat.com, mark.rutland@arm.com, philmd@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH v3 01/14] arm/cpu: Add sysreg definitions in cpu-sysregs.h In-Reply-To: <7c6ab887-2c9f-6646-4f0c-790671b28c62@redhat.com> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <20250311162824.199721-1-cohuck@redhat.com> <20250311162824.199721-2-cohuck@redhat.com> <7c6ab887-2c9f-6646-4f0c-790671b28c62@redhat.com> User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Date: Fri, 21 Mar 2025 16:29:13 +0100 Message-ID: <87v7s2tnau.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.332, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Mar 20 2025, Sebastian Ott wrote: > On Tue, 11 Mar 2025, Cornelia Huck wrote: >> +++ b/target/arm/cpu.h > [...] >> +/* REG is ID_XXX */ >> +#define FIELD_DP64_IDREG(ISAR, REG, FIELD, VALUE) \ >> + ({ \ >> + ARMISARegisters *i_ = (ISAR); \ >> + uint64_t regval = i_->idregs[REG ## _EL1_IDX]; \ > > This won't work for regs that don't fit this naming scheme. Up to this > point in the series that's only CTR_EL0, later with the auto generation it > will be more. But I guess this can be extended when/if there's an actual > need.. All ID_XXX registers fit the "has an _EL1 suffix" scheme, though, and these are what we use the _IDREG() accessors for (we use FIELD_DP64 for CTR_EL0 fields.) (At least, that matches what I see called "ID registers" in the Arm Arm.) The sysregs we get via KVM_ARM_GET_REG_WRITABLE_MASKS/KVM_ARM_FEATURE_ID_RANGE contain ID_XXX registers, and some more writable registers in the feature id range which are not really id registers (but which we want to handle via the command line as well). I think all the non _EL1 registers we want to handle fall into the latter category (i.e. we're not going to use the _IDREG() accessors for them?)