From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, Fabiano Rosas <farosas@suse.de>,
qemu-block@nongnu.org, Leonardo Bras <leobras@redhat.com>,
Peter Xu <peterx@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Fam Zheng <fam@euphon.net>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH v6 3/5] migration: migrate 'blk' command option is deprecated.
Date: Tue, 17 Oct 2023 22:54:32 +0200 [thread overview]
Message-ID: <87v8b5x94n.fsf@secure.mitica> (raw)
In-Reply-To: <20231017172307.22858-4-quintela@redhat.com> (Juan Quintela's message of "Tue, 17 Oct 2023 19:23:05 +0200")
Juan Quintela <quintela@redhat.com> wrote:
> Use blocked-mirror with NBD instead.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Hi Kevin and Stefan
Can we change the iotest output to fix this?
https://gitlab.com/juan.quintela/qemu/-/jobs/5314070229
tput mismatch (see /builds/juan.quintela/qemu/build/tests/qemu-iotests/scratch/raw-file-183/183.out.bad)
--- /builds/juan.quintela/qemu/tests/qemu-iotests/183.out
+++ /builds/juan.quintela/qemu/build/tests/qemu-iotests/scratch/raw-file-183/183.out.bad
@@ -28,6 +28,8 @@
{ 'execute': 'migrate',
'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } }
+warning: parameter 'blk is deprecated; use blockdev-mirror with NBD instead
+warning: block migration is deprecated; use blockdev-mirror with NBD instead
{"return": {}}
{ 'execute': 'query-status' }
{"return": {"status": "postmigrate", "singlestep": false, "running":
false}}
I really want to give the warnings two users.
I guess that you want to test blk migration.
What do you recommend?
Later, Juan.
next prev parent reply other threads:[~2023-10-17 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 17:23 [PATCH v6 0/5] Migration deprecated parts Juan Quintela
2023-10-17 17:23 ` [PATCH v6 1/5] migration: Print block status when needed Juan Quintela
2023-10-17 17:23 ` [PATCH v6 2/5] migration: migrate 'inc' command option is deprecated Juan Quintela
2023-10-18 8:30 ` Markus Armbruster
2023-10-18 10:22 ` Juan Quintela
2023-10-17 17:23 ` [PATCH v6 3/5] migration: migrate 'blk' " Juan Quintela
2023-10-17 20:54 ` Juan Quintela [this message]
2023-10-17 17:23 ` [PATCH v6 4/5] migration: Deprecate block migration Juan Quintela
2023-10-17 17:23 ` [PATCH v6 5/5] migration: Deprecate old compression method Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8b5x94n.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=libvir-list@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).