From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] hw/virtio/vhost: Silence compiler warnings in vhost code when using -Wshadow
Date: Fri, 06 Oct 2023 13:38:27 +0200 [thread overview]
Message-ID: <87v8bkj80c.fsf@pond.sub.org> (raw)
In-Reply-To: <20231006072416-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Fri, 6 Oct 2023 07:24:34 -0400")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Fri, Oct 06, 2023 at 01:45:51PM +0300, Michael Tokarev wrote:
>> 06.10.2023 11:55, Markus Armbruster пишет:
>> > Michael Tokarev <mjt@tls.msk.ru> writes:
>> >
>> > > Applied to my trivial-patches tree, thanks!
>> > >
>> > > Marcus, you picked up previous patches of this theme, --
>> > > you can continue this tradition if you like :)
>> >
>> > I intend to post a pull request for the -Wshadow patches that have
>> > R-bys. I'm also tracking the unreviewed ones, and hope they get
>> > reviewed.
>>
>> Ahh, ok.
>>
>> I've added my own R-bys for the ones I picked up, and for this one
>> by Thomas too:
>>
>> Reviewed-By: Michael Tokarev <mjt@tls.msk.ru>
>>
>> /mjt
>
> it would be better to deal with all of them in one place tbh.
I just sent a pull request. Thanks for all the reviews!
next prev parent reply other threads:[~2023-10-06 11:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 11:48 [PATCH] hw/virtio/vhost: Silence compiler warnings in vhost code when using -Wshadow Thomas Huth
2023-10-04 12:51 ` Michael S. Tsirkin
2023-10-06 6:26 ` Michael Tokarev
2023-10-06 8:55 ` Markus Armbruster
2023-10-06 10:45 ` Michael Tokarev
2023-10-06 10:51 ` Markus Armbruster
2023-10-06 11:24 ` Michael S. Tsirkin
2023-10-06 11:38 ` Markus Armbruster [this message]
2023-10-07 9:28 ` Michael Tokarev
2023-10-09 6:02 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8bkj80c.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).