qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Sam Li <faithilikerun@gmail.com>
Cc: qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
	stefanha@redhat.com, "David Hildenbrand" <david@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	dmitry.fomichev@wdc.com, "Eric Blake" <eblake@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	dlemoal@kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	hare@suse.de, qemu-block@nongnu.org
Subject: Re: [RFC 2/5] qcow2: add zone device metadata with zd_extension
Date: Mon, 21 Aug 2023 15:17:00 +0200	[thread overview]
Message-ID: <87v8d8bkmr.fsf@pond.sub.org> (raw)
In-Reply-To: <20230816064617.3310-3-faithilikerun@gmail.com> (Sam Li's message of "Wed, 16 Aug 2023 14:46:14 +0800")

Sam Li <faithilikerun@gmail.com> writes:

> Zone descriptor data is host definied data that is associated with
> each zone. Add zone descriptor extensions to zonedmeta and
> blk_get_zone_extension to access zd_extensions.
>
> Signed-off-by: Sam Li <faithilikerun@gmail.com>

[...]

> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0c97ae678b..f71dd18fc3 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -5024,6 +5024,8 @@
>  #                 (default: off, since 8.0)
>  # @zone-size: The size of a zone of the zoned device (since 8.0)
>  # @zone-capacity: The capacity of a zone of the zoned device (since 8.0)
> +# @zd-extension-size: Zone descriptor extension size. Must be a multiple of
> +#                     64 bytes (since 8.0)
>  # @zone-nr-conv: The number of conventional zones of the zoned device
>  #                (since 8.0)
>  # @max-open-zones: The maximal allowed open zones (since 8.0)

For better or worse, we tend to avoid abbreviations in QAPI schema
names.  Would @zone-descriptor-extension-size be too unwieldy?

> @@ -5052,6 +5054,7 @@
>              '*zoned-profile':      'str',
>              '*zone-size':          'size',
>              '*zone-capacity':      'size',
> +            '*zd-extension-size':  'size',
>              '*zone-nr-conv':       'uint32',
>              '*max-open-zones':     'uint32',
>              '*max-active-zones':   'uint32',



  reply	other threads:[~2023-08-21 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16  6:46 [RFC 0/5] Add persistence to NVMe ZNS emulation Sam Li
2023-08-16  6:46 ` [RFC 1/5] hw/nvme: use blk_get_*() to access zone info in the block layer Sam Li
2023-08-16  6:46 ` [RFC 2/5] qcow2: add zone device metadata with zd_extension Sam Li
2023-08-21 13:17   ` Markus Armbruster [this message]
2023-08-16  6:46 ` [RFC 3/5] hw/nvme: make the metadata of ZNS emulation persistent Sam Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8d8bkmr.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=david@redhat.com \
    --cc=dlemoal@kernel.org \
    --cc=dmitry.fomichev@wdc.com \
    --cc=eblake@redhat.com \
    --cc=faithilikerun@gmail.com \
    --cc=hare@suse.de \
    --cc=hreitz@redhat.com \
    --cc=its@irrelevant.dk \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).