From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE936EE4993 for ; Mon, 21 Aug 2023 13:17:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY4mN-00036f-Hy; Mon, 21 Aug 2023 09:17:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY4mL-00035y-NQ for qemu-devel@nongnu.org; Mon, 21 Aug 2023 09:17:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY4mJ-0004lY-M0 for qemu-devel@nongnu.org; Mon, 21 Aug 2023 09:17:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692623825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wxLoAAWoE5TSJSUdGXuNz54lA9anxfl1DOJa4VDZZfE=; b=QUC8N+LWVzE6oaLhymFEztPmDVV5kdDkVlM7J6PUTt8JP137VHsF0fgAOnCWf5TJJCSd42 HpqvLiOV+b3a2GfjXkepx2NGGtwq/sHIpFQHw0D0bASwNPwECiLz1zMOp7MHMydRHFAMmZ La+AXNdm2hWp0rrUwlkFy+tyadERvLo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-14-wbRLs2quPfOgNMnLujnlIw-1; Mon, 21 Aug 2023 09:17:02 -0400 X-MC-Unique: wbRLs2quPfOgNMnLujnlIw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB2C0101AA4E; Mon, 21 Aug 2023 13:17:01 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55969492C13; Mon, 21 Aug 2023 13:17:01 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5409021E690D; Mon, 21 Aug 2023 15:17:00 +0200 (CEST) From: Markus Armbruster To: Sam Li Cc: qemu-devel@nongnu.org, Peter Xu , stefanha@redhat.com, David Hildenbrand , Kevin Wolf , Keith Busch , Hanna Reitz , dmitry.fomichev@wdc.com, Eric Blake , Klaus Jensen , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , dlemoal@kernel.org, Paolo Bonzini , hare@suse.de, qemu-block@nongnu.org Subject: Re: [RFC 2/5] qcow2: add zone device metadata with zd_extension References: <20230816064617.3310-1-faithilikerun@gmail.com> <20230816064617.3310-3-faithilikerun@gmail.com> Date: Mon, 21 Aug 2023 15:17:00 +0200 In-Reply-To: <20230816064617.3310-3-faithilikerun@gmail.com> (Sam Li's message of "Wed, 16 Aug 2023 14:46:14 +0800") Message-ID: <87v8d8bkmr.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sam Li writes: > Zone descriptor data is host definied data that is associated with > each zone. Add zone descriptor extensions to zonedmeta and > blk_get_zone_extension to access zd_extensions. > > Signed-off-by: Sam Li [...] > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 0c97ae678b..f71dd18fc3 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -5024,6 +5024,8 @@ > # (default: off, since 8.0) > # @zone-size: The size of a zone of the zoned device (since 8.0) > # @zone-capacity: The capacity of a zone of the zoned device (since 8.0) > +# @zd-extension-size: Zone descriptor extension size. Must be a multiple of > +# 64 bytes (since 8.0) > # @zone-nr-conv: The number of conventional zones of the zoned device > # (since 8.0) > # @max-open-zones: The maximal allowed open zones (since 8.0) For better or worse, we tend to avoid abbreviations in QAPI schema names. Would @zone-descriptor-extension-size be too unwieldy? > @@ -5052,6 +5054,7 @@ > '*zoned-profile': 'str', > '*zone-size': 'size', > '*zone-capacity': 'size', > + '*zd-extension-size': 'size', > '*zone-nr-conv': 'uint32', > '*max-open-zones': 'uint32', > '*max-active-zones': 'uint32',