From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35D5AC38142 for ; Fri, 27 Jan 2023 13:52:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLP8q-0004c9-B3; Fri, 27 Jan 2023 08:51:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLP8p-0004by-4w for qemu-devel@nongnu.org; Fri, 27 Jan 2023 08:51:43 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLP8n-0004Ut-EQ for qemu-devel@nongnu.org; Fri, 27 Jan 2023 08:51:42 -0500 Received: by mail-wr1-x42c.google.com with SMTP id h12so5017235wrv.10 for ; Fri, 27 Jan 2023 05:51:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=bJLI3EKVzySsj1W2B7b0Hx5IVsnSD8qm2kGpGqIXMI4=; b=FoaBhhP4foC1PmFS9tL3stEbtkz8H/fytA/Jmh8V43M9xM8zHyK80fAumOpaBLNUIm CrhfLdbkb1LibsfOXTYLLq8dfxvDL/rSwk7bXq3zcheWXhPfzBj5NK8EO9JoNcvS+u1Z CLt1W46ze9vqn79yZgl3VDbZgd0LiHqh1PhIBnRzHrg8CYTKvAMOdULT82QtmGPbsFia vbNkPZsWFeOtmJva3tbR8g+yd4ks31j6en+pBfpkJW46+j8r7KUckloN6XsOIhYhO1bu p9lV3zX4VxNfu9ww2qke+QGQPPHpm323CwbUO7kWUg6SCIE21DxPi6Mymy4YuAuOaxJ9 cA3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bJLI3EKVzySsj1W2B7b0Hx5IVsnSD8qm2kGpGqIXMI4=; b=rABwRZQvzZF0Ak2cZ4drHosyhPxta14keAoAJZj8Qz1AW2ubsiSsAYqhmbtQkJ1JWd 1FWHxXLdxVRET3c6ud5iEOmxEGXgKbYqEIqE/AXX5xF+Kl2zROUiPrTfDg0Q/618CcUa YxMfOfKUbV1U+nMsmwANlk2MzsYyl54+SgHpL4LXSW5UsicwAs/fSF3Ichcu1Ak/fxuU fk0kRnKd0KFYleEaOhgqAszjVuhyejMpt+3oqFILWzgy6TkiQeKfY9he9HftPgOyjLcp ujyolNJHniNgJf3GVFNaVm4CiFGBvGRS3/RDJlQ6+u7kIT5EVnO3yxdj1KaWTQwqayqp DP0Q== X-Gm-Message-State: AFqh2krMTQrnn6zQtXCd6cgFAYxX7S0pEbePAfcWwWgfJhXUlKAWCFxG 5IGoEvBFmQ7hy2PzboSOOcEq6Q== X-Google-Smtp-Source: AMrXdXsqdooRwYWnRmeWwVoe0WZZA/ZFCuQmaIeQgsdYXVWdS6HbY/4Rgj32jINdLNci+ZYLQVRmVQ== X-Received: by 2002:a5d:6b4d:0:b0:2bb:f88b:43b6 with SMTP id x13-20020a5d6b4d000000b002bbf88b43b6mr35293202wrw.3.1674827499890; Fri, 27 Jan 2023 05:51:39 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id f7-20020a5d64c7000000b002bdfe3aca17sm4488106wri.51.2023.01.27.05.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 05:51:39 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id EF3A81FFB7; Fri, 27 Jan 2023 13:51:38 +0000 (GMT) References: <20230126043824.54819-1-richard.henderson@linaro.org> <20230126043824.54819-9-richard.henderson@linaro.org> User-agent: mu4e 1.9.16; emacs 29.0.60 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 08/36] include/qemu/int128: Use Int128 structure for TCI Date: Fri, 27 Jan 2023 13:51:34 +0000 In-reply-to: <20230126043824.54819-9-richard.henderson@linaro.org> Message-ID: <87v8ksnl05.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Richard Henderson writes: > We are about to allow passing Int128 to/from tcg helper functions, > but libffi doesn't support __int128_t, so use the structure. > > In order for atomic128.h to continue working, we must provide > a mechanism to frob between real __int128_t and the structure. > Provide a new union, Int128Alias, for this. We cannot modify > Int128 itself, as any changed alignment would also break libffi. > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro