From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712E4C47089 for ; Thu, 27 May 2021 14:03:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EECA610A0 for ; Thu, 27 May 2021 14:03:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EECA610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGbh-0000od-5t for qemu-devel@archiver.kernel.org; Thu, 27 May 2021 10:03:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmGZb-0007Wo-GN for qemu-devel@nongnu.org; Thu, 27 May 2021 10:01:19 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:38654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmGZX-0006jF-4G for qemu-devel@nongnu.org; Thu, 27 May 2021 10:01:19 -0400 Received: by mail-wr1-x42c.google.com with SMTP id j14so4870808wrq.5 for ; Thu, 27 May 2021 07:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=Cr/A6ZqtjGfm5+0Z8Ta2bpQ9xb1tlcVNRdKU53wVMFs=; b=eQKioEI6U0UI0NOutgoSHnzKiRWnKA7FcScMB8GKhvdu4XjSDMcfoPDUKpAMj39MLC K9lSZFR2W2bAC7O6IGH5p2GICtMqFmDw14rQ2lDPaAQJkTfxv/Ffoa7WtLfsUnOlX6Yf HX5dXB8y3wM18V9bw/3v1n65Jn0n3KbbrSDSWF1w5aUxyhDVOjjJ3A5wfOozc38QSfw6 R5CdWs7vuCY64XicS5tnyhftW4+oNe9hq+2fqWQvw2fsPqLFS/MkrvBTTois6fpdeS0V uXTNgBQqcaqEMyIPthoBLAOltFyS65LXK+p5mZm+C+7L6xol+bKP355NkW0DcgpKstdy 5Z+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=Cr/A6ZqtjGfm5+0Z8Ta2bpQ9xb1tlcVNRdKU53wVMFs=; b=DCJeCQRrJF5vBBUsv6APP5bz+C9D9fClWNjwpbNAPUbvJJ+aCMWUWON7qNIJHg64fe KkER6iDFKXwR2TvgWd+6/UiYxXuKxwpAcuR1+7EL13kt2lP1KF1+epIQzYGSWqsR1j8C jcpxmZJR3KBU6ZvoMVan7FFF71wUtae08y9cu+dYy+cKxMAoXvPydS9KOErhcjVEmd6g Os1XsDEYRf+4J97X0RrXKlyMO59rLLHLo2msrhBBg7evdsNoINDrFa6ZOkrfIpdi8D60 bmm7KOxMOL617Qp1boNHOhduiPI3dr0y5Gr/B3AJKKpeHmqqF1Fe1f+1LmAz8rb2ifgp 0VkQ== X-Gm-Message-State: AOAM532mmVw31BagN80xs8r1i4qKRjrU8WKTHmIOlngns8x9B9if/V95 3LpSk4BuSp6IX2CUADJH50aDRQ== X-Google-Smtp-Source: ABdhPJy+wi9ZAvCEPVYhC6/g8Ed5Lg1tCakgBDib+x0nN3o7sGLTzjVL0Zn7tsbIJkORw8ZzliCNNA== X-Received: by 2002:adf:bc07:: with SMTP id s7mr686532wrg.301.1622124072230; Thu, 27 May 2021 07:01:12 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 60sm3302861wrq.14.2021.05.27.07.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 07:01:11 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7DC8A1FF7E; Thu, 27 May 2021 15:01:10 +0100 (BST) References: <20210526202104.127910-1-bruno.larsen@eldorado.org.br> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: "Bruno Larsen (billionai)" Subject: Re: [PATCH 0/5] stop collection of instruction usage statistics Date: Thu, 27 May 2021 14:57:51 +0100 In-reply-to: <20210526202104.127910-1-bruno.larsen@eldorado.org.br> Message-ID: <87v9741djt.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, richard.henderson@linaro.org, lucas.araujo@eldorado.org.br, qemu-devel@nongnu.org, luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Bruno Larsen (billionai)" writes: > Based-on: <20210525115355.8254-1-bruno.larsen@eldorado.org.br> > > The functionality of counting how many instructions were being executed a= nd > being able to show it through the monitor, although neat, was only > supported by ppc, and now that it is migrating to use decodetree (at > least partially), those statistics won't be used anymore. Therefore, > this patch removes that functinality completely. I have no particular comment to make about the PPC stuff but with the common translator loop we have hooks across all converted front ends to identify the start of each instruction. It's needed for the TCG plugin instrumentation and we could in theory use it for more integrated stats across the board. Out of interest what was the main aim of this code - a view of total executed instructions or something more detailed like a breakdown of types and ops? > > This series was suggested by Richard Henderson > > Bruno Larsen (billionai) (5): > target/ppc: fixed GEN_OPCODE behavior when PPC_DUMP_CPU is set > target/ppc: remove ppc_cpu_dump_statistics > target/ppc: removed mentions to DO_PPC_STATISTICS > monitor: removed cpustats command > hw/core/cpu: removed cpu_dump_statistics function > > hmp-commands-info.hx | 13 -------- > hw/core/cpu.c | 9 ------ > include/hw/core/cpu.h | 12 -------- > monitor/misc.c | 11 ------- > target/ppc/cpu.h | 1 - > target/ppc/cpu_init.c | 3 -- > target/ppc/translate.c | 69 +++--------------------------------------- > 7 files changed, 5 insertions(+), 113 deletions(-) --=20 Alex Benn=C3=A9e