From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59953C433B4 for ; Tue, 6 Apr 2021 09:46:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEDA261222 for ; Tue, 6 Apr 2021 09:46:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEDA261222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTiHy-00018b-Rj for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 05:46:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTiGx-0000dq-Uq for qemu-devel@nongnu.org; Tue, 06 Apr 2021 05:45:23 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:34497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTiGs-0007AL-NF for qemu-devel@nongnu.org; Tue, 06 Apr 2021 05:45:23 -0400 Received: by mail-wr1-x436.google.com with SMTP id b9so5595418wrs.1 for ; Tue, 06 Apr 2021 02:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=+XKO3oY9mBdmq9QChfcjoxlkMvBL8lSpM9uI+GOkEZ4=; b=PgtUdM2UMsd8S3Yq8OWrBbZ4rvq2uFAtztqUjQXpUnOMSEmYMm7c6EBV2vfNX205uo lvGagy0oJMNSIrQOsujoYN6KEZm9l0FEPe+jH/tpvQa64xzxQWp3mi/d3B51dfp0lmQG 6rvBKG7gJyc82DRSOiWMr5Jo7z8TwxzUqzDmi9uheps96NcLlPO/UM9m9tTmCsESzDa0 eBR13G+oMW1h5dAYIQiNVSzOQ+h8ylBneGjzmRTFju+yJ7bS+SYEUraKdY4MwX9+88m7 GE8cMNeY8mYCruVwCtPBOc4qwRcs9YiGgM7dS96ZkUX5KLonmZPd1cxo49buKBH0Gmq5 JEAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=+XKO3oY9mBdmq9QChfcjoxlkMvBL8lSpM9uI+GOkEZ4=; b=WkBYgaeTjvC2pmb8xpxqqVIhbh9VdeU6ENtp+to5X1GyBwKm9MxnpWzUTAD6HkrKCV SL/nATadmuddi0NF9np+xdp9XOdaj3H8adRt4NTCy9Qc6s9oHu4IJrYZWt86hYcs9XPA KyYXS2VIL/tALApxd4SenLKPbfM5PCpehQM55RKvkFRrX7UpUUZ0LgTw+8w/lK2zE31L VYy9Eodik+KX0bEYAHjhKZ0QrOk8/PiHn8d5sro2LGuC1y+1hCLInVUJ8UPxRbibopKg JbjMmNtR878CM7ZRMoOBsJwHSONdt0J8Ncc57mu3wo4BllkWtmBlyxPTbGIiMbdkt0a9 dw6w== X-Gm-Message-State: AOAM530cxEjtIgdrF+k0YBlrnPHYrGzdou9Jlya7sVJ+O8eKW3yg4VC4 PPu/CCYKqxHcZuE9D2OanTQDQA== X-Google-Smtp-Source: ABdhPJztB4j/ocIZj1yq/quuEYjOO0qMb9varv92O4Sm8lTiZAeBL6cgN//1izGMu1OvQPrp5K46Qg== X-Received: by 2002:adf:f742:: with SMTP id z2mr33014068wrp.130.1617702316247; Tue, 06 Apr 2021 02:45:16 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a65sm2232482wme.17.2021.04.06.02.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 02:45:14 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2D8451FF7E; Tue, 6 Apr 2021 10:45:14 +0100 (BST) References: <20210401102530.12030-1-alex.bennee@linaro.org> <20210401102530.12030-8-alex.bennee@linaro.org> User-agent: mu4e 1.5.11; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Subject: Re: [PATCH v2 07/11] tests/tcg: relax the next step precision of the gdb sha1 test Date: Tue, 06 Apr 2021 10:43:47 +0100 In-reply-to: Message-ID: <87v98zwxud.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, qemu-devel@nongnu.org, f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Richard Henderson writes: > On 4/1/21 3:25 AM, Alex Benn=C3=A9e wrote: >> check_break("SHA1Init") >> - # check step and inspect values >> + # Check step and inspect values. We do a double next after the >> + # breakpoint as depending on the version of gdb we may step the >> + # preamble and not the first actual line of source. >> + gdb.execute("next") >> gdb.execute("next") >> val_ctx =3D gdb.parse_and_eval("context->state[0]") >> exp_ctx =3D 0x67452301 > > This double next seems just as fragile. Why don't you just set the > breakpoint where you want, which appears to be sha1.c:138? Ideally I'd want an unambiguous label that gdb would understand lest it got broken by someone tweaking the sha1.c code. I thought a function header would be better but it appears only marginally so.=20 > > > r~ --=20 Alex Benn=C3=A9e