From: "Alex Bennée" <alex.bennee@linaro.org>
To: Chen Qun <kuhn.chenqun@huawei.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org,
"Riku Voipio" <riku.voipio@iki.fi>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, ganqixin@huawei.com,
"Euler Robot" <euler.robot@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v3 3/7] accel/tcg/user-exec: silence the compiler warnings
Date: Mon, 16 Nov 2020 13:36:16 +0000 [thread overview]
Message-ID: <87v9e5whin.fsf@linaro.org> (raw)
In-Reply-To: <20201116024810.2415819-4-kuhn.chenqun@huawei.com>
Chen Qun <kuhn.chenqun@huawei.com> writes:
> When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showed warning:
> ../accel/tcg/user-exec.c: In function ‘handle_cpu_signal’:
> ../accel/tcg/user-exec.c:169:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 169 | cpu_exit_tb_from_sighandler(cpu, old_set);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../accel/tcg/user-exec.c:172:9: note: here
> 172 | default:
>
> Mark the cpu_exit_tb_from_sighandler() function with QEMU_NORETURN to fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2020-11-16 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 2:48 [PATCH v3 0/7] silence the compiler warnings Chen Qun
2020-11-16 2:48 ` [PATCH v3 1/7] target/i386: silence the compiler warnings in gen_shiftd_rm_T1 Chen Qun
2020-11-16 2:48 ` [PATCH v3 2/7] hw/intc/arm_gicv3_kvm: silence the compiler warnings Chen Qun
2020-11-16 2:48 ` [PATCH v3 3/7] accel/tcg/user-exec: " Chen Qun
2020-11-16 13:36 ` Alex Bennée [this message]
2020-11-16 2:48 ` [PATCH v3 4/7] target/sparc/translate: " Chen Qun
2020-11-16 2:48 ` [PATCH v3 5/7] target/sparc/win_helper: " Chen Qun
2020-11-16 2:48 ` [PATCH v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN Chen Qun
2020-11-16 11:46 ` [PATCH-for-5.2 " Philippe Mathieu-Daudé
2020-11-23 5:46 ` David Gibson
2020-11-23 5:46 ` [PATCH " David Gibson
2020-11-16 2:48 ` [PATCH v3 7/7] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings Chen Qun
2020-11-23 5:45 ` David Gibson
2020-12-11 2:22 ` [PATCH v3 0/7] silence the compiler warnings Chenqun (kuhn)
2020-12-11 8:30 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9e5whin.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=euler.robot@huawei.com \
--cc=f4bug@amsat.org \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=thuth@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).